From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzRH9-00056m-5x for qemu-devel@nongnu.org; Fri, 02 Sep 2011 06:47:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QzRH7-0004RZ-Nu for qemu-devel@nongnu.org; Fri, 02 Sep 2011 06:47:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8275) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzRH7-0004RP-Gu for qemu-devel@nongnu.org; Fri, 02 Sep 2011 06:47:05 -0400 Date: Fri, 2 Sep 2011 13:45:12 +0300 From: Alon Levy Message-ID: <20110902104512.GC27006@bow> References: <20110813212356.GA6981@rox.home.comstyle.com> <20110822173456.GA14284@rox.home.comstyle.com> <20110902101032.GA23431@stefanha-thinkpad.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110902101032.GA23431@stefanha-thinkpad.localdomain> Subject: Re: [Qemu-devel] [PATCH] libcacard: use INSTALL_DATA for data List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Brad On Fri, Sep 02, 2011 at 11:10:32AM +0100, Stefan Hajnoczi wrote: > On Mon, Aug 22, 2011 at 01:34:57PM -0400, Brad wrote: > > On Sat, Aug 13, 2011 at 05:23:57PM -0400, Brad wrote: > > > libcacard: use INSTALL_DATA for data > > > > > > Signed-off-by: Brad Smith > > > > > > --- > > > libcacard/Makefile | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/libcacard/Makefile b/libcacard/Makefile > > > index 5cd7594..fe9747a 100644 > > > --- a/libcacard/Makefile > > > +++ b/libcacard/Makefile > > > @@ -54,7 +54,7 @@ install-libcacard: libcacard.pc libcacard.la vscclient > > > $(INSTALL_DIR) "$(DESTDIR)$(libcacard_includedir)" > > > $(INSTALL_DIR) "$(DESTDIR)$(bindir)" > > > libtool --mode=install $(INSTALL_PROG) vscclient "$(DESTDIR)$(bindir)" > > > - libtool --mode=install $(INSTALL_PROG) libcacard.la "$(DESTDIR)$(libdir)" > > > + libtool --mode=install $(INSTALL_DATA) libcacard.la "$(DESTDIR)$(libdir)" > > > libtool --mode=install $(INSTALL_DATA) libcacard.pc "$(DESTDIR)$(libdir)/pkgconfig" > > > for inc in *.h; do \ > > > libtool --mode=install $(INSTALL_DATA) $(libcacard_srcpath)/$$inc "$(DESTDIR)$(libcacard_includedir)"; \ > > > -- > > > 1.7.6 > > > > An updated diff against up to date master. > > > > > > libcacard: use INSTALL_DATA for data > > > > Signed-off-by: Brad Smith > > > > --- > > libcacard/Makefile | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > Thanks, applied to the trivial patches tree: > http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches > Thanks, my bad for not doing a pull request. > Stefan >