From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46347)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QzX3i-0005Vk-UJ
	for qemu-devel@nongnu.org; Fri, 02 Sep 2011 12:57:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QzX3h-0003Pt-VV
	for qemu-devel@nongnu.org; Fri, 02 Sep 2011 12:57:38 -0400
Received: from mx1.redhat.com ([209.132.183.28]:3316)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QzX3h-0003Pc-Lw
	for qemu-devel@nongnu.org; Fri, 02 Sep 2011 12:57:37 -0400
Date: Fri, 2 Sep 2011 13:57:31 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20110902135731.1f29371b@doriath>
In-Reply-To: <4E610828.8050007@us.ibm.com>
References: <1314211389-28915-1-git-send-email-aliguori@us.ibm.com>
	<1314211389-28915-4-git-send-email-aliguori@us.ibm.com>
	<4E567724.7020601@linux.vnet.ibm.com>
	<4E60FDB2.7060708@codemonkey.ws> <20110902130931.50b0f63a@doriath>
	<4E6104F5.6010202@linux.vnet.ibm.com> <4E610828.8050007@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/14] qapi: use middle mode in QMP server
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org

On Fri, 02 Sep 2011 11:45:28 -0500
Anthony Liguori <aliguori@us.ibm.com> wrote:

> On 09/02/2011 11:31 AM, Michael Roth wrote:
> 
> >>> This ended up being a bit harder than I initially thought so I'd prefer
> >>> to delay this to another series so we can start converting commands to
> >>> QAPI ASAP.
> >>
> >> Fine with me.
> >
> > Same. Curious what the complications are though, I wouldn't mind looking
> > at it.
> 
> The current dispatch and error checking logic in the QMP server scares 
> me.  It wasn't immediately obvious if just adding another else clause in 
> the dispatch logic was enough.

It inherited HMP's distinction between "info" and "regular" commands plus
the arg_type thing.

IMO, the best thing to do is to let it alone for now, do the QAPI conversion
and then drop it in favor on the new server.