qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded
Date: Fri, 2 Sep 2011 14:27:26 -0300	[thread overview]
Message-ID: <20110902142726.4839f5d6@doriath> (raw)
In-Reply-To: <cover.1314370059.git.jan.kiszka@siemens.com>

On Fri, 26 Aug 2011 16:48:10 +0200
Jan Kiszka <jan.kiszka@siemens.com> wrote:

> More than one year ago I posted some patches to add a monitor command
> callend device_show. The purpose of that command is to dump the state of
> some qdev device based on its vmstate.
> 
> To improve the usability of that interface, the previous series also
> tried to create a canonical qdev tree path name format and even added
> monitor command expansion. That format created quite a few discussions,
> and we never came to some conclusion.
> 
> As device_show is still a useful tool for debugging but qdev structuring
> and addressing may significantly change in the near future, I decided to
> reanimate those patches while avoiding almost any change of the
> addressing scheme. The only one I propose is automatic ID assignment for
> anonymous devices so that any qdev device is in principle addressable
> (e.g. APIC and IO-APIC on x86).
> 
> As back then, device_show remains HMP-only to avoid any stable ABI
> issues around QMP.
> 
> CC: Luiz Capitulino <lcapitulino@redhat.com>
> CC: Markus Armbruster <armbru@redhat.com>

This looks good to me and I'm willing to apply it. Only issue I'd like to see
resolved is the base64 encoder/decoder. This series introduces a new one,
while the guest agent uses glib's.

I think we should choose one of them and stick to it.

Any other objections apart from that? Markus?

  parent reply	other threads:[~2011-09-02 17:27 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-26 14:48 [Qemu-devel] [PATCH 0/6] Device state visualization reloaded Jan Kiszka
2011-08-26 14:48 ` [Qemu-devel] [PATCH 1/6] monitor: return length of printed string via monitor_[v]printf Jan Kiszka
2011-08-26 14:48 ` [Qemu-devel] [PATCH 2/6] Add base64 encoder/decoder Jan Kiszka
2011-08-26 15:21   ` Peter Maydell
2011-08-26 15:23     ` Jan Kiszka
2011-08-26 15:47       ` Jan Kiszka
2011-08-26 18:02         ` Jan Kiszka
2011-09-02 17:22           ` Luiz Capitulino
2011-09-05 13:55         ` [Qemu-devel] required glib version? " Gerd Hoffmann
2011-08-26 14:48 ` [Qemu-devel] [PATCH 3/6] QMP: Reserve namespace for complex object classes Jan Kiszka
2011-09-02 17:23   ` Luiz Capitulino
2011-09-02 17:47     ` Jan Kiszka
2011-09-02 18:02     ` Anthony Liguori
2011-08-26 14:48 ` [Qemu-devel] [PATCH 4/6] QMP: Add QBuffer Jan Kiszka
2011-08-26 18:23   ` [Qemu-devel] [PATCH v2 " Jan Kiszka
2011-08-26 14:48 ` [Qemu-devel] [PATCH 5/6] monitor: Add basic device state visualization Jan Kiszka
2011-08-26 14:48 ` [Qemu-devel] [PATCH 6/6] qdev: Generate IDs for anonymous devices Jan Kiszka
2011-08-29 19:23   ` Anthony Liguori
2011-08-29 20:56     ` Jan Kiszka
2011-08-29 21:19       ` Anthony Liguori
2011-08-31 18:31         ` Jan Kiszka
2011-09-07  9:50           ` Gleb Natapov
2011-09-07 10:27             ` Jan Kiszka
2011-09-07 10:34               ` Gleb Natapov
2011-09-07 10:58                 ` Jan Kiszka
2011-08-29 19:22 ` [Qemu-devel] [PATCH 0/6] Device state visualization reloaded Anthony Liguori
2011-08-29 20:54   ` Jan Kiszka
2011-09-02 17:27 ` Luiz Capitulino [this message]
2011-09-06 14:48 ` Michael S. Tsirkin
2011-09-06 15:45   ` Jan Kiszka
2011-09-06 15:51     ` Anthony Liguori
2011-09-06 16:05       ` Jan Kiszka
2011-09-06 16:08         ` Anthony Liguori
2011-09-06 16:33           ` Jan Kiszka
2011-09-06 16:09       ` Michael S. Tsirkin
2011-09-06 16:28         ` Anthony Liguori
2011-09-06 17:05           ` Michael S. Tsirkin
2011-09-07  9:37             ` Kevin Wolf
2011-09-07 13:06               ` Michael S. Tsirkin
2011-09-07 13:13                 ` Jan Kiszka
2011-09-07 13:17                   ` Michael S. Tsirkin
2011-09-07 13:23                     ` Anthony Liguori
2011-09-07 13:29                       ` Jan Kiszka
2011-09-07 13:33                       ` Michael S. Tsirkin
2011-09-06 16:29         ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110902142726.4839f5d6@doriath \
    --to=lcapitulino@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).