From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:41062)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dan@berrange.com>) id 1QzWlX-0001PP-1B
	for qemu-devel@nongnu.org; Fri, 02 Sep 2011 12:38:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dan@berrange.com>) id 1QzWlQ-000701-H0
	for qemu-devel@nongnu.org; Fri, 02 Sep 2011 12:38:45 -0400
Received: from www.berrange.com ([80.68.90.122]:53315)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dan@berrange.com>) id 1QzWlP-0006zX-T5
	for qemu-devel@nongnu.org; Fri, 02 Sep 2011 12:38:44 -0400
Date: Fri, 2 Sep 2011 17:38:42 +0100
From: "Daniel P. Berrange" <dan@berrange.com>
Message-ID: <20110902163842.GA13413@berrange.com>
References: <1314975700-20235-1-git-send-email-dan@berrange.com>
	<CAJSP0QUiOdXk+qWUckKaFk-KUJ-xtefMys1W=hxC-P4xYo-3LA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJSP0QUiOdXk+qWUckKaFk-KUJ-xtefMys1W=hxC-P4xYo-3LA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Display sector count in 'info block'	output
Reply-To: "Daniel P. Berrange" <dan@berrange.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org

On Fri, Sep 02, 2011 at 04:37:24PM +0100, Stefan Hajnoczi wrote:
> On Fri, Sep 2, 2011 at 4:01 PM, Daniel P. Berrange <dan@berrange.com> wrote:
> > From: "Daniel P. Berrange" <dan@berrange.com>
> >
> > To aid in knowing whether a 'block_resize' was succesful, display
> > the sector count in the 'info block' output
> >
> > Signed-off-by: Daniel P. Berrange <dan@berrange.com>
> > ---
> >  block.c         |    6 ++++--
> >  qmp-commands.hx |    1 +
> >  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> Please use bdrv_getlength().  That way units are in bytes, not
> "sectors" (could be confusing, e.g. on 4 KB devices).  Also for
> "growable" block devices we actually query instead of reading the
> cached total_sectors field.

Good points, I've sent a v2 using bytes instead of sectors.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|