From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0FWs-0002gL-Lg for qemu-devel@nongnu.org; Sun, 04 Sep 2011 12:26:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R0FWm-0004Dn-89 for qemu-devel@nongnu.org; Sun, 04 Sep 2011 12:26:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13271) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0FWl-0004DV-V6 for qemu-devel@nongnu.org; Sun, 04 Sep 2011 12:26:36 -0400 Date: Sun, 4 Sep 2011 19:27:05 +0300 From: "Michael S. Tsirkin" Message-ID: <20110904162705.GA12745@redhat.com> References: <20110831143551.127339744@linux.vnet.ibm.com> <20110831143621.194691516@linux.vnet.ibm.com> <20110901172726.GG10989@redhat.com> <4E60304A.4040204@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E60304A.4040204@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH V8 07/14] Implementation of the libtpms-based backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Berger Cc: chrisw@redhat.com, anbang.ruan@cs.ox.ac.uk, qemu-devel@nongnu.org, rrelyea@redhat.com, alevy@redhat.com, andreas.niederl@iaik.tugraz.at, serge@hallyn.com On Thu, Sep 01, 2011 at 09:24:26PM -0400, Stefan Berger wrote: > In patch 6 I am adding a skeleton backend driver that I am > transforming into the libtpms-based backend in patch 7. I didn't > name the file tpm_skeleton.c but already tpm_builtin.c and all > functions already start with the prefix tpm_builtin. This presumably > makes it easier to review since the 'meat' is added in part 7 and > unnecessary function name changes are avoided. It is a good idea to split your code to patches. But you don't need your code to actually work in an intermediate step - or even compile if it is not added to the Makefile. That will help reviewers by sending small patches and not waste reviewer's time on reading code removed in a later patch. -- MST