From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40457) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0U1S-00011l-Rx for qemu-devel@nongnu.org; Mon, 05 Sep 2011 03:55:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R0U1P-00034e-T8 for qemu-devel@nongnu.org; Mon, 05 Sep 2011 03:55:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12868) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0U1P-00034a-Gf for qemu-devel@nongnu.org; Mon, 05 Sep 2011 03:55:11 -0400 Date: Mon, 5 Sep 2011 10:55:59 +0300 From: "Michael S. Tsirkin" Message-ID: <20110905075559.GA16038@redhat.com> References: <1314853263-2086-1-git-send-email-david@gibson.dropbear.id.au> <1314853263-2086-2-git-send-email-david@gibson.dropbear.id.au> <20110901153550.GC10989@redhat.com> <20110902043825.GX11906@yookeroo.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110902043825.GX11906@yookeroo.fritz.box> Subject: Re: [Qemu-devel] [PATCH 01/10] Add stub functions for PCI device models to do PCI DMA List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, joerg.roedel@amd.com, aliguori@us.ibm.com, rth@twiddle.net, agraf@suse.de, eduard.munteanu@linux360.ro On Fri, Sep 02, 2011 at 02:38:25PM +1000, David Gibson wrote: > > I'd prefer the stubs to be inline. Not just as an optimization: > > it also makes it easier to grok what goes on in the common > > no-iommu case. > > To elaborate on my earlier mail. The problem with making them inlines > is that the cpu_physical_*() functions then appear in pci.h, which is > used in pci.c amongst other places that are included in > libhw32/libhw64, where those functions are poisoned. Hmm, how are they poisoned? I thought almost all devices currently use cpu_physical_*()? For example, e1000 uses cpu_physical_memory_write and it seems to get included in libhw32/libhw64 without issues. > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson