From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:51550)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1R0ZVd-0001py-UF
	for qemu-devel@nongnu.org; Mon, 05 Sep 2011 09:46:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1R0ZVc-0007Z0-VL
	for qemu-devel@nongnu.org; Mon, 05 Sep 2011 09:46:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:3082)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1R0ZVc-0007Yi-Fg
	for qemu-devel@nongnu.org; Mon, 05 Sep 2011 09:46:44 -0400
Date: Mon, 5 Sep 2011 16:44:51 +0300
From: Alon Levy <alevy@redhat.com>
Message-ID: <20110905134451.GA32375@bow.tlv.redhat.com>
References: <1314976794-31931-1-git-send-email-kraxel@redhat.com>
	<4E633A37.40208@redhat.com> <4E649033.2040105@redhat.com>
	<20110905104700.GN27006@bow> <4E64CEC3.3030108@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E64CEC3.3030108@redhat.com>
Subject: Re: [Qemu-devel] [Spice-devel] [PATCH] server: don't call
 reds_stream_free from worker thread context
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Yonit Halperin <yhalperi@redhat.com>, qemu-devel@nongnu.org, spice-devel@freedesktop.org

On Mon, Sep 05, 2011 at 03:29:39PM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> >I verified it still calls reds_stream_free from the worker thread, only
> >now the call itself is done in red_channel.c (via red_channel_disconnect
> >or something like that), which is called from red_worker.c
> 
> Where the code in red_channel.c is now shared for all channel types?
> Hmm.  That makes it a bit harder to change the workflow I guess ...

can do the usual (well, done once in hw/qxl.c) trick of

 if (pthread_id() == stored_thread_id_from_main_channel_creation) {
   write_to_pipe_read_in_main_thread
 } else {
   real_reds_stream_free();
 }

> 
> cheers,
>   Gerd
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel