From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35731) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0zW2-0003Jt-6V for qemu-devel@nongnu.org; Tue, 06 Sep 2011 13:32:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R0zVx-00031H-RR for qemu-devel@nongnu.org; Tue, 06 Sep 2011 13:32:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22465) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0zVx-00031D-Gn for qemu-devel@nongnu.org; Tue, 06 Sep 2011 13:32:49 -0400 Date: Tue, 6 Sep 2011 20:05:30 +0300 From: "Michael S. Tsirkin" Message-ID: <20110906170529.GA22871@redhat.com> References: <20110906144828.GA20834@redhat.com> <4E66402C.2020900@siemens.com> <4E66417E.6040308@codemonkey.ws> <20110906160903.GA21675@redhat.com> <4E664A19.5000207@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E664A19.5000207@codemonkey.ws> Subject: Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Jan Kiszka , Anthony Liguori , Luiz Capitulino , qemu-devel , Markus Armbruster On Tue, Sep 06, 2011 at 11:28:09AM -0500, Anthony Liguori wrote: > On 09/06/2011 11:09 AM, Michael S. Tsirkin wrote: > >On Tue, Sep 06, 2011 at 10:51:26AM -0500, Anthony Liguori wrote: > >>On 09/06/2011 10:45 AM, Jan Kiszka wrote: > >>>On 2011-09-06 16:48, Michael S. Tsirkin wrote: > >>>>I'm afraid that won't be enough to stop people > >>>>scripting this command - libvirt accessed > >>>>HMP for years. > >>>> > >>>>On the other hand, no QMP command means e.g. > >>>>libvirt users don't get any benefit from this. > >>>> > >>>>What I think will solve these problems, for both HMP and QMP, > >>>>is an explicit 'debug_unstable' or 'debug_unsupported' command that will > >>>>expose all kind of debugging functionality making it > >>>>very explicit that it's an unsupported debugging utility. > >>>> > >>>>Proposed syntax: > >>>> > >>>>debug_unstable > >>>> > >>>>Example: > >>>> > >>>>debug_unstable device_show -all > >>> > >>>For HMP, this would needlessly complicate the user interface, nothing I > >>>would support. People scripting things on top of HMP are generally doing > >>>this on their own risk and cannot expect output stability. > >>> > >>>device_show is like info qtree: the output will naturally change as the > >>>emulated hardware evolves, information is added/removed, or we simply > >>>improve the layout. Recent changes on info network are an example for > >>>the latter. > >> > >>Yeah, I'm not worried about stability. HMP commands that aren't > >>exposed as QMP commands are inherently unstable and should not be > >>scripted to. > > > >They are also not accessible when using libvirt, right? > > $ virsh human-monitor-passthrough GuestName device_show foo > > Should work. So how, in the end, will user know it's unsupported? I don't agree with 'all HMP is unstable' as people will use it and will come to depend on it. What I'm asking is something like 'enable_unsupported_commands', which will expose all kind of stuff. Could also be extra stuff in existing commands too - e.g. info pci is a natural way to see config space for devices. -- MST