From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:38518)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1R1GDm-0001x7-FE
	for qemu-devel@nongnu.org; Wed, 07 Sep 2011 07:23:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1R1GDl-0007KC-Kb
	for qemu-devel@nongnu.org; Wed, 07 Sep 2011 07:23:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:25565)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1R1GDl-0007K8-CG
	for qemu-devel@nongnu.org; Wed, 07 Sep 2011 07:23:09 -0400
Date: Wed, 7 Sep 2011 14:23:34 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20110907112334.GC9337@redhat.com>
References: <20110831143551.127339744@linux.vnet.ibm.com>
	<20110831143625.419705972@linux.vnet.ibm.com>
	<20110901181024.GJ10989@redhat.com>
	<4E6046E8.60403@linux.vnet.ibm.com>
	<20110904163814.GC12745@redhat.com>
	<4E66DACE.3010706@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E66DACE.3010706@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH V8 14/14] Allow to provide inital TPM state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: chrisw@redhat.com, anbang.ruan@cs.ox.ac.uk, qemu-devel@nongnu.org, rrelyea@redhat.com, alevy@redhat.com, andreas.niederl@iaik.tugraz.at, serge@hallyn.com

On Tue, Sep 06, 2011 at 10:45:34PM -0400, Stefan Berger wrote:
> On 09/04/2011 12:38 PM, Michael S. Tsirkin wrote:
> >On Thu, Sep 01, 2011 at 11:00:56PM -0400, Stefan Berger wrote:
> >
> >initstate_fd=<file descriptor>
> >initstate_base64=on/off (or base64/bin if you really expect
> >	more formats in the future)
> >
> >and use qemu routines to get the fd so they can be
> >passed through the monitor later ...
> >
> I suppose you mean monitor_get_fd(). That functions seems to only be
> used by net.c so far and if  understand the chain of functions
> correctly that are called with the monitor as parameter it helps in
> hotplugging net devices ? For the TPM I would like to *not* have
> support for hotplugging since that device is supposed to be soldered
> to the motherboard and needs to be initialized through a command
> sequence by the (v)BIOS, so it has to be present early on during
> machine startup.
> 
>   Stefan

Fine, but let's reuse common functions and save code duplication,
especially parsing functions.