qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Yehuda Sadeh <yehuda@hq.newdream.net>
Cc: sage@newdream.net, ceph-devel@vger.kernel.org,
	yehudasa@gmail.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] improve qemu-img conversion performance
Date: Thu, 8 Sep 2011 08:56:28 +0100	[thread overview]
Message-ID: <20110908075628.GA23849@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <cover.1315436097.git.yehuda@hq.newdream.net>

On Wed, Sep 07, 2011 at 04:06:51PM -0700, Yehuda Sadeh wrote:
> The following set of patches improve the qemu-img conversion process
> performance. When using a higher latency backend, small writes have a
> severe impact on the time it takes to do image conversion. 
> We switch to using async writes, and we avoid splitting writes due to
> holes when the holes are small enough.
> 
> Yehuda Sadeh (2):
>   qemu-img: async write to block device when converting image
>   qemu-img: don't skip writing small holes
> 
>  qemu-img.c |   34 +++++++++++++++++++++++++++-------
>  1 files changed, 27 insertions(+), 7 deletions(-)
> 
> -- 
> 2.7.5.1

This has nothing to do with the patch itself, but I've been curious
about the existence of both a QEMU and a Linux kernel rbd block driver.

The I/O latency with qemu-img has been an issue for rbd users.  But they
have the option of using the Linux kernel rbd block driver, where
qemu-img can take advantage of the page cache instead of performing
direct I/O.

Does this mean you intend to support both QEMU block/rbd.c and Linux
drivers/block/rbd.c?  As a user I would go with the Linux kernel driver
instead of the QEMU block driver because it offers page cache and host
block device features.  On the other hand a userspace driver is nice
because it does not require privileges.

Stefan

  parent reply	other threads:[~2011-09-08  7:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-07 23:06 [Qemu-devel] [PATCH 0/2] improve qemu-img conversion performance Yehuda Sadeh
2011-09-07 23:06 ` [Qemu-devel] [PATCH 1/2] qemu-img: async write to block device when converting image Yehuda Sadeh
2011-09-08  4:18   ` Sage Weil
2011-09-07 23:06 ` [Qemu-devel] [PATCH 2/2] qemu-img: don't skip writing small holes Yehuda Sadeh
2011-09-08  7:56 ` Stefan Hajnoczi [this message]
2011-09-09  4:52   ` [Qemu-devel] [PATCH 0/2] improve qemu-img conversion performance Sage Weil
2011-09-08 14:13 ` Kevin Wolf
2011-09-08 16:36   ` Sage Weil
2011-09-09  8:18     ` Kevin Wolf
2011-09-12  3:14       ` Sage Weil
2011-09-12  3:17         ` Yehuda Sadeh Weinraub
2011-09-12  7:42           ` Yehuda Sadeh Weinraub
2011-09-12  8:05           ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110908075628.GA23849@stefanha-thinkpad.localdomain \
    --to=stefanha@gmail.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sage@newdream.net \
    --cc=yehuda@hq.newdream.net \
    --cc=yehudasa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).