From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48857)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1R35YP-0007yC-0V
	for qemu-devel@nongnu.org; Mon, 12 Sep 2011 08:24:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1R35YM-0007iw-Vj
	for qemu-devel@nongnu.org; Mon, 12 Sep 2011 08:24:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:1028)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1R35YM-0007im-H2
	for qemu-devel@nongnu.org; Mon, 12 Sep 2011 08:23:58 -0400
Date: Mon, 12 Sep 2011 15:24:59 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20110912122458.GC12294@redhat.com>
References: <1749303074.590739.1315551830460.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
	<1466280941.590770.1315552101666.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
	<20110909073226.GB5593@redhat.com>
	<1315587902.2662.19.camel@x201.home>
	<20110909183426.GD22662@amt.cnet>
	<20110911092357.GC27096@redhat.com>
	<20110911150149.GA28477@amt.cnet>
	<20110911185106.GA4740@redhat.com>
	<20110912102148.GA12332@amt.cnet> <20110912105607.GA12849@amt.cnet>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110912105607.GA12849@amt.cnet>
Subject: Re: [Qemu-devel] About hotplug multifunction
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, blauwirbel@gmail.com, yamahata@valinux.co.jp, Alex Williamson <alex.williamson@redhat.com>, Amos Kong <akong@redhat.com>

On Mon, Sep 12, 2011 at 07:56:07AM -0300, Marcelo Tosatti wrote:
> On Mon, Sep 12, 2011 at 07:21:48AM -0300, Marcelo Tosatti wrote:
> > > We could, for example, keep a stub function 0 around.
> > 
> > I suppose the guest will remove all functions of a device once you
> > attempt to hot-unplug a function.
> > 
> > What is the problem with adding more PCI buses, instead of multifunction
> > ?
> 
> The advantage is that its not only possible to use virtio devices, but any
> kind of PCI device.

Yes. But it is a new feature. Creating multifunction devs is
*already* possible. Hotplug is partially broken,
so getting it into a consistent non buggy state has
value imho.

-- 
MST