From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/4] Sparc: convert mmu_helper to trace framework
Date: Tue, 13 Sep 2011 08:59:38 +0100 [thread overview]
Message-ID: <20110913075938.GD14528@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <CAAu8pHt4QgGFQOgSNg9=ma54gwdKLJxpVDCfoQ3xwtQ8881zJA@mail.gmail.com>
On Sun, Sep 11, 2011 at 04:41:10PM +0000, Blue Swirl wrote:
> +mmu_helper_dmiss(uint64_t address, uint64_t context) "DMISS at
> %"PRIx64" context %"PRIx64
> +mmu_helper_tfault(uint64_t address, uint64_t context) "TFAULT at
> %"PRIx64" context %"PRIx64
> +mmu_helper_tmiss(uint64_t address, uint64_t context) "TMISS at
> %"PRIx64" context %"PRIx64
>From docs/tracing.txt:
format strings must begin and end with double quotes. When using
portability macros, ensure they are preceded and followed by double
quotes:
"value %"PRIx64""
This is a parser limitation in scripts/tracetool. We could change it to
treat everything after the trace event arguments as the format string,
but today it explicitly looks for a pattern like ".*".
I've added this to my tracing TODO list and it should be possible to
lift the limitation soon. For now, please make sure the format string
begins and ends with double quote.
Stefan
prev parent reply other threads:[~2011-09-13 7:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-11 16:41 [Qemu-devel] [PATCH 1/4] Sparc: convert mmu_helper to trace framework Blue Swirl
2011-09-13 7:59 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110913075938.GD14528@stefanha-thinkpad.localdomain \
--to=stefanha@linux.vnet.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).