From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3PqY-0002pg-H8 for qemu-devel@nongnu.org; Tue, 13 Sep 2011 06:04:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R3PqQ-00086A-BH for qemu-devel@nongnu.org; Tue, 13 Sep 2011 06:04:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21300) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3PqQ-00085y-30 for qemu-devel@nongnu.org; Tue, 13 Sep 2011 06:03:58 -0400 Date: Tue, 13 Sep 2011 13:05:00 +0300 From: "Michael S. Tsirkin" Message-ID: <20110913100500.GB29872@redhat.com> References: <1749303074.590739.1315551830460.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> <1466280941.590770.1315552101666.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> <20110909174311.GC24594@valinux.co.jp> <20110911090517.GB27096@redhat.com> <20110913055720.GO24594@valinux.co.jp> <20110913065249.GN21417@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110913065249.GN21417@redhat.com> Subject: Re: [Qemu-devel] About hotplug multifunction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, blauwirbel@gmail.com, Isaku Yamahata , Alex Williamson , Amos Kong On Tue, Sep 13, 2011 at 09:52:49AM +0300, Gleb Natapov wrote: > On Tue, Sep 13, 2011 at 02:57:20PM +0900, Isaku Yamahata wrote: > > On Sun, Sep 11, 2011 at 12:05:17PM +0300, Michael S. Tsirkin wrote: > > > On Sat, Sep 10, 2011 at 02:43:11AM +0900, Isaku Yamahata wrote: > > > > pci/pcie hot plug needs clean up for multifunction hotplug in long term. > > > > Only single function device case works. Multifunction case is broken somwehat. > > > > Especially the current acpi based hotplug should be replaced by > > > > the standardized hot plug controller in long term. > > > > > > We'll need to keep supporting windows XP, which IIUC only > > > supports hotplug through ACPI. So it looks like we'll > > > need both. > > > > Yes, we'll need both then. > > It would be possible to implement acpi-based hotplug with > > standardized hotplug controller. Not with qemu-specific controller. > > > Where is this "standardized hotplug controller" documented? Sorry both pci bridge and hotplug spec only reference shpc. The spec itself is PCI Standard Hot-Plug Controller and Subsystem Specification. Revision 1.0 - get it from pcisig > > It would require a bit amount of work to write ACPI code in DSDT that > > handles standardized hotplug controller. > > So I'm not sure it's worth while only for windows XP support. > > -- > > yamahata > > -- > Gleb.