From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:51568)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1R4Csp-0003RV-Ps
	for qemu-devel@nongnu.org; Thu, 15 Sep 2011 10:25:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1R4Csl-0003Ym-Nu
	for qemu-devel@nongnu.org; Thu, 15 Sep 2011 10:25:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:2281)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1R4Csl-0003YX-G8
	for qemu-devel@nongnu.org; Thu, 15 Sep 2011 10:25:39 -0400
Date: Thu, 15 Sep 2011 17:25:34 +0300
From: Gleb Natapov <gleb@redhat.com>
Message-ID: <20110915142534.GC11524@redhat.com>
References: <4E70EC90.8000904@us.ibm.com> <20110915063121.GW21417@redhat.com>
	<4E720435.3060509@codemonkey.ws> <4E720855.1090501@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E720855.1090501@redhat.com>
Subject: Re: [Qemu-devel] [RFC] Plan for moving forward with QOM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, Jan Kiszka <jan.kiszka@siemens.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>

On Thu, Sep 15, 2011 at 04:14:45PM +0200, Paolo Bonzini wrote:
> On 09/15/2011 03:57 PM, Anthony Liguori wrote:
> >
> >void generate_tree(Device *node)
> >{
> >    if (IS_PCI_BUS(node)) {
> >       for (i = 0; i < 32; i++) {
> >          generate_tree(lookup_device(get_property(node, "slot[%d]", i)));
> >       }
> >    } else if (IS_ISA_BUS(node)) {
> >       ....
> >    } else {
> >       // leaf node, generate path segment
> >    }
> >}
> >
> >There are certainly ways to walk the graph generically (by coloring or
> >following the composition paths) but that won't give you the desired
> >ordering.
> 
> It seems easier to go backwards from the target device.
That what we do in qdev.

> 
> Each device most likely will have a canonical parent link, and
> together they will give the OF path.
> 
Yeah, this canonical parent link should be marked somehow.

--
			Gleb.