From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5eXk-0008Qc-LQ for qemu-devel@nongnu.org; Mon, 19 Sep 2011 10:10:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R5eXd-00032Y-Fu for qemu-devel@nongnu.org; Mon, 19 Sep 2011 10:09:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21130) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5eXd-000323-8a for qemu-devel@nongnu.org; Mon, 19 Sep 2011 10:09:49 -0400 Date: Mon, 19 Sep 2011 11:09:45 -0300 From: Luiz Capitulino Message-ID: <20110919110945.5a9cb43c@doriath> In-Reply-To: <4E774636.7050500@redhat.com> References: <1314902275-5240-1-git-send-email-lcapitulino@redhat.com> <4E774636.7050500@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 0/6]: block: Add I/O status support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, armbru@redhat.com On Mon, 19 Sep 2011 15:40:06 +0200 Kevin Wolf wrote: > Am 01.09.2011 20:37, schrieb Luiz Capitulino: > > This series adds support to the block layer to keep track of devices' > > I/O status. That information is also made available in QMP and HMP. > > > > The goal here is to allow management applications that miss the > > BLOCK_IO_ERROR event to able to query the VM to determine if any device has > > caused the VM to stop and which device caused it. > > > > Please, note that this series depends on the following series: > > > > o [PATCH v3 0/8]: Introduce the RunState type > > o http://lists.gnu.org/archive/html/qemu-devel/2011-09/msg00118.html > > > > And to be able to properly test it you'll also need: > > > > o [PATCH 0/3] qcow2/coroutine fixes > > o http://lists.gnu.org/archive/html/qemu-devel/2011-09/msg00074.html > > > > Here's an HMP example: > > > > (qemu) info status > > VM status: paused (io-error) > > (qemu) info block > > ide0-hd0: removable=0 io-status=ok file=disks/test2.img ro=0 drv=qcow2 encrypted=0 > > ide0-hd1: removable=0 io-status=nospace file=/dev/vg_doriath/kvmtest ro=0 drv=qcow2 encrypted=0 > > ide1-cd0: removable=1 locked=0 io-status=ok [not inserted] > > floppy0: removable=1 locked=0 [not inserted] > > sd0: removable=1 locked=0 [not inserted] > > > > The "info status" command shows that the VM is stopped due to an I/O error. > > By issuing "info block" it's possible to determine that the 'ide0-hd1' device > > caused the error, which turns out to be due to no space. > > Looks like I didn't reply here yet? No, you didn't. > I still don't quite like that the devices are involved, but their part > is minimal and it makes the implementation much easier, so for me that's > acceptable. Suggestions on better ways of implementing this are welcome! :)