From: Mathieu Desnoyers <compudj@krystal.dyndns.org>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: ltt-dev@lists.casi.polymtl.ca,
"Lluís Vilanova" <vilanova@ac.upc.edu>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [ltt-dev] [PATCH 2/3] trace: [ust] Do not use 'm' in event argument names (used by ust macros)
Date: Tue, 20 Sep 2011 10:22:22 -0400 [thread overview]
Message-ID: <20110920142222.GA13869@Krystal> (raw)
In-Reply-To: <20110920115202.GB23976@stefanha-thinkpad.localdomain>
* Stefan Hajnoczi (stefanha@gmail.com) wrote:
> On Fri, Sep 16, 2011 at 06:59:38PM +0200, Lluís Vilanova wrote:
> > Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> > ---
> > trace-events | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/trace-events b/trace-events
> > index 9d1fbbb..b653d70 100644
> > --- a/trace-events
> > +++ b/trace-events
> > @@ -418,8 +418,8 @@ milkymist_pfpu_pulse_irq(void) "Pulse IRQ"
> > # hw/milkymist-softusb.c
> > milkymist_softusb_memory_read(uint32_t addr, uint32_t value) "addr %08x value %08x"
> > milkymist_softusb_memory_write(uint32_t addr, uint32_t value) "addr %08x value %08x"
> > -milkymist_softusb_mevt(uint8_t m) "m %d"
> > -milkymist_softusb_kevt(uint8_t m) "m %d"
> > +milkymist_softusb_mevt(uint8_t _m) "m %d"
> > +milkymist_softusb_kevt(uint8_t _m) "m %d"
>
> The LTTng community has been very responsive in addressing namespace
> issues with libust. Let's post more details and see if it can be fixed
> in libust.
>
> Could you please post your gcc and libust versions?
>
> I have not been able to reproduce the problem on Debian libust-dev
> 0.15-3. My gcc version is Debian gcc 4.6.1-4.
>
> Here is the test program:
>
> #include <stdint.h>
> #include <ust/tracepoint.h>
>
> DECLARE_TRACE(ust_milkymist_softusb_mevt, TP_PROTO(uint8_t m),
> TP_ARGS(m));
>
> int main(int argc, char **argv)
> {
> return 0;
> }
>
> I see no warning or error related to the 'm' argument name.
(sorry for re-send, I just fixed my SMTP setup)
I remember fixing that for trace_mark() instrumentation in UST 0.x ages
ago (ok, probably last winter). I think simply updating to a new UST
version will fix the issue.
Best regards,
Mathieu
>
> Stefan
>
> _______________________________________________
> ltt-dev mailing list
> ltt-dev@lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>
--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2011-09-20 14:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-16 16:59 [Qemu-devel] [PATCH 1/3] trace: Fix print format for "mipsnet_write" Lluís Vilanova
2011-09-16 16:59 ` [Qemu-devel] [PATCH 2/3] trace: [ust] Do not use 'm' in event argument names (used by ust macros) Lluís Vilanova
2011-09-20 11:52 ` Stefan Hajnoczi
2011-09-20 12:55 ` Lluís Vilanova
2011-09-20 14:31 ` [Qemu-devel] [ltt-dev] " Mathieu Desnoyers
2011-09-20 14:41 ` Stefan Hajnoczi
2011-09-20 15:12 ` Lluís Vilanova
2011-09-20 16:22 ` Mathieu Desnoyers
2011-09-20 16:22 ` Mathieu Desnoyers
2011-09-21 8:28 ` Stefan Hajnoczi
2011-09-20 13:03 ` P DUMAS
2011-09-20 14:22 ` Mathieu Desnoyers [this message]
2011-09-20 11:58 ` [Qemu-devel] " Stefan Hajnoczi
2011-09-16 16:59 ` [Qemu-devel] [PATCH 3/3] trace: [ust] Do not use zero-length format strings (avoid compiler warning) Lluís Vilanova
2011-09-20 7:32 ` [Qemu-devel] [PATCH 1/3] trace: Fix print format for "mipsnet_write" Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110920142222.GA13869@Krystal \
--to=compudj@krystal.dyndns.org \
--cc=ltt-dev@lists.casi.polymtl.ca \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).