From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R61DQ-0000z1-0Q for qemu-devel@nongnu.org; Tue, 20 Sep 2011 10:22:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R61DN-0008Tw-RD for qemu-devel@nongnu.org; Tue, 20 Sep 2011 10:22:27 -0400 Received: from mail.openrapids.net ([64.15.138.104]:41486 helo=blackscsi.openrapids.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R61DN-0008Tg-OP for qemu-devel@nongnu.org; Tue, 20 Sep 2011 10:22:25 -0400 Received: from localhost (localhost [127.0.0.1]) by blackscsi.openrapids.net (Postfix) with ESMTP id 3183A140446 for ; Tue, 20 Sep 2011 10:22:24 -0400 (EDT) Received: from blackscsi.openrapids.net ([127.0.0.1]) by localhost (blackscsi.openrapids.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9KIIsPsk4VIE for ; Tue, 20 Sep 2011 10:22:24 -0400 (EDT) Received: from krystal.dyndns.org (localhost [127.0.0.1]) by blackscsi.openrapids.net (Postfix) with ESMTP id F3F2E140455 for ; Tue, 20 Sep 2011 10:22:22 -0400 (EDT) Date: Tue, 20 Sep 2011 10:22:22 -0400 From: Mathieu Desnoyers Message-ID: <20110920142222.GA13869@Krystal> References: <20110916165933.16620.4383.stgit@ginnungagap.bsc.es> <20110916165938.16620.54932.stgit@ginnungagap.bsc.es> <20110920115202.GB23976@stefanha-thinkpad.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20110920115202.GB23976@stefanha-thinkpad.localdomain> Subject: Re: [Qemu-devel] [ltt-dev] [PATCH 2/3] trace: [ust] Do not use 'm' in event argument names (used by ust macros) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: ltt-dev@lists.casi.polymtl.ca, =?iso-8859-1?Q?Llu=EDs?= Vilanova , qemu-devel@nongnu.org * Stefan Hajnoczi (stefanha@gmail.com) wrote: > On Fri, Sep 16, 2011 at 06:59:38PM +0200, Llu=EDs Vilanova wrote: > > Signed-off-by: Llu=EDs Vilanova > > --- > > trace-events | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > >=20 > > diff --git a/trace-events b/trace-events > > index 9d1fbbb..b653d70 100644 > > --- a/trace-events > > +++ b/trace-events > > @@ -418,8 +418,8 @@ milkymist_pfpu_pulse_irq(void) "Pulse IRQ" > > # hw/milkymist-softusb.c > > milkymist_softusb_memory_read(uint32_t addr, uint32_t value) "addr %08= x value %08x" > > milkymist_softusb_memory_write(uint32_t addr, uint32_t value) "addr %0= 8x value %08x" > > -milkymist_softusb_mevt(uint8_t m) "m %d" > > -milkymist_softusb_kevt(uint8_t m) "m %d" > > +milkymist_softusb_mevt(uint8_t _m) "m %d" > > +milkymist_softusb_kevt(uint8_t _m) "m %d" >=20 > The LTTng community has been very responsive in addressing namespace > issues with libust. Let's post more details and see if it can be fixed > in libust. >=20 > Could you please post your gcc and libust versions? >=20 > I have not been able to reproduce the problem on Debian libust-dev > 0.15-3. My gcc version is Debian gcc 4.6.1-4. >=20 > Here is the test program: >=20 > #include > #include >=20 > DECLARE_TRACE(ust_milkymist_softusb_mevt, TP_PROTO(uint8_t m), > TP_ARGS(m)); >=20 > int main(int argc, char **argv) > { > return 0; > } >=20 > I see no warning or error related to the 'm' argument name. (sorry for re-send, I just fixed my SMTP setup) I remember fixing that for trace_mark() instrumentation in UST 0.x ages ago (ok, probably last winter). I think simply updating to a new UST version will fix the issue. Best regards, Mathieu >=20 > Stefan >=20 > _______________________________________________ > ltt-dev mailing list > ltt-dev@lists.casi.polymtl.ca > http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev >=20 --=20 Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com