From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R61Ly-0004qJ-77 for qemu-devel@nongnu.org; Tue, 20 Sep 2011 10:31:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R61Lw-0001xY-F4 for qemu-devel@nongnu.org; Tue, 20 Sep 2011 10:31:18 -0400 Received: from mail.openrapids.net ([64.15.138.104]:55677 helo=blackscsi.openrapids.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R61Lw-0001xE-8k for qemu-devel@nongnu.org; Tue, 20 Sep 2011 10:31:16 -0400 Received: from localhost (localhost [127.0.0.1]) by blackscsi.openrapids.net (Postfix) with ESMTP id 2F02D140454 for ; Tue, 20 Sep 2011 10:31:15 -0400 (EDT) Received: from blackscsi.openrapids.net ([127.0.0.1]) by localhost (blackscsi.openrapids.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s6TRPZ2KFBZ3 for ; Tue, 20 Sep 2011 10:31:15 -0400 (EDT) Received: from krystal.dyndns.org (localhost [127.0.0.1]) by blackscsi.openrapids.net (Postfix) with ESMTP id 34A18140456 for ; Tue, 20 Sep 2011 10:31:13 -0400 (EDT) Date: Tue, 20 Sep 2011 10:31:12 -0400 From: Mathieu Desnoyers Message-ID: <20110920143112.GA14814@Krystal> References: <20110916165933.16620.4383.stgit@ginnungagap.bsc.es> <20110916165938.16620.54932.stgit@ginnungagap.bsc.es> <20110920115202.GB23976@stefanha-thinkpad.localdomain> <87ty87z849.fsf@ginnungagap.bsc.es> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <87ty87z849.fsf@ginnungagap.bsc.es> Subject: Re: [Qemu-devel] [ltt-dev] [PATCH 2/3] trace: [ust] Do not use 'm' in event argument names (used by ust macros) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Llu=EDs?= Vilanova Cc: Stefan Hajnoczi , ltt-dev@lists.casi.polymtl.ca, qemu-devel@nongnu.org * Llu=C3=ADs Vilanova (vilanova@ac.upc.edu) wrote: > Stefan Hajnoczi writes: >=20 > > On Fri, Sep 16, 2011 at 06:59:38PM +0200, Llu=C3=ADs Vilanova wrote: > >> Signed-off-by: Llu=C3=ADs Vilanova > >> --- > >> trace-events | 4 ++-- > >> 1 files changed, 2 insertions(+), 2 deletions(-) > >>=20 > >> diff --git a/trace-events b/trace-events > >> index 9d1fbbb..b653d70 100644 > >> --- a/trace-events > >> +++ b/trace-events > >> @@ -418,8 +418,8 @@ milkymist_pfpu_pulse_irq(void) "Pulse IRQ" > >> # hw/milkymist-softusb.c > >> milkymist_softusb_memory_read(uint32_t addr, uint32_t value) "addr %08= x value %08x" > >> milkymist_softusb_memory_write(uint32_t addr, uint32_t value) "addr %0= 8x value %08x" > >> -milkymist_softusb_mevt(uint8_t m) "m %d" > >> -milkymist_softusb_kevt(uint8_t m) "m %d" > >> +milkymist_softusb_mevt(uint8_t _m) "m %d" > >> +milkymist_softusb_kevt(uint8_t _m) "m %d" >=20 > > The LTTng community has been very responsive in addressing namespace > > issues with libust. Let's post more details and see if it can be fixed > > in libust. >=20 > > Could you please post your gcc and libust versions? >=20 > > I have not been able to reproduce the problem on Debian libust-dev > > 0.15-3. My gcc version is Debian gcc 4.6.1-4. >=20 > Yup, I was using libust-dev 0.5 (debian stable). After switching to 0.15 = (debian > testing) other problems arise. >=20 > For example, in my box compiling osdep.c yields lots of "variable =E2=80= =98__tp_cb_data=E2=80=99 > set but not used", but using a minimal example does not raise such proble= ms, so > I'm assuming this is related to some namespace problems related to some o= ther > code in qemu's headers. If you can find a few minutes to provide: 1) a link to the git repository/commit ID you are testing 2) the exact configuration you use (detailed way to reproduce the problem, as a sequence of commands from a pristine repository) It will allow me to look into this warning and fix it. Thanks! Mathieu >=20 > Unfortunately, right now I have no time to debug the causes, so I'll just= assume > the two patches I sent (this naming issue and the zero-length printf form= at) are > just no longer necessary with recent versions of libust. >=20 >=20 > Thanks, > Lluis >=20 > --=20 > "And it's much the same thing with knowledge, for whenever you learn > something new, the whole world becomes that much richer." > -- The Princess of Pure Reason, as told by Norton Juster in The Phantom > Tollbooth >=20 > _______________________________________________ > ltt-dev mailing list > ltt-dev@lists.casi.polymtl.ca > http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev --=20 Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com