From: Mathieu Desnoyers <compudj@krystal.dyndns.org>
To: "Lluís Vilanova" <vilanova@ac.upc.edu>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
ltt-dev@lists.casi.polymtl.ca, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [ltt-dev] [PATCH 2/3] trace: [ust] Do not use 'm' in event argument names (used by ust macros)
Date: Tue, 20 Sep 2011 12:22:39 -0400 [thread overview]
Message-ID: <20110920162239.GA30824@Krystal> (raw)
In-Reply-To: <87k493w8mt.fsf@ginnungagap.bsc.es>
* Lluís Vilanova (vilanova@ac.upc.edu) wrote:
>
> I don't know about the portability requirements in UST, but if supporting only
> gcc is an option, you can simply use this line in the macro:
>
> void *__tp_cb_data __attribute__((unused));
>
Done. See commit 34dca3cc6e0b230c988b16117b967a094560f4ed.
> Even with this fixed, there still seem to be problems with events without
> parameters:
>
> DECLARE_TRACE(ust_slavio_misc_update_irq_raise, TP_PROTO(void), TP_ARGS());
> #define trace_slavio_misc_update_irq_raise trace_ust_slavio_misc_update_irq_raise
>
> ./trace.h: In function ‘__trace_ust_slavio_misc_update_irq_raise’:
> ./trace.h:361:1: error: ‘void’ must be the only parameter
> ./trace.h:361:1: error: expected expression before ‘)’ token
> ./trace.h:361:1: error: too many arguments to function ‘(void (*)(void *))__tp_it_func’
>
TRACEPOINT_EVENT_NOARGS(name, TP_FIELDS()) should be used there.
Thanks!
Mathieu
> The debian/testing version of ust is 0.15, and the sources have a ChangeLog with
> this at the top:
>
> 2011-07-15 ust 0.15
> * Add backward compability for tracepoint API (still planned for
> deprecation, but should make the transition smoother).
>
>
> Lluis
>
> --
> "And it's much the same thing with knowledge, for whenever you learn
> something new, the whole world becomes that much richer."
> -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
> Tollbooth
>
--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2011-09-20 16:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-16 16:59 [Qemu-devel] [PATCH 1/3] trace: Fix print format for "mipsnet_write" Lluís Vilanova
2011-09-16 16:59 ` [Qemu-devel] [PATCH 2/3] trace: [ust] Do not use 'm' in event argument names (used by ust macros) Lluís Vilanova
2011-09-20 11:52 ` Stefan Hajnoczi
2011-09-20 12:55 ` Lluís Vilanova
2011-09-20 14:31 ` [Qemu-devel] [ltt-dev] " Mathieu Desnoyers
2011-09-20 14:41 ` Stefan Hajnoczi
2011-09-20 15:12 ` Lluís Vilanova
2011-09-20 16:22 ` Mathieu Desnoyers [this message]
2011-09-20 16:22 ` Mathieu Desnoyers
2011-09-21 8:28 ` Stefan Hajnoczi
2011-09-20 13:03 ` P DUMAS
2011-09-20 14:22 ` Mathieu Desnoyers
2011-09-20 11:58 ` [Qemu-devel] " Stefan Hajnoczi
2011-09-16 16:59 ` [Qemu-devel] [PATCH 3/3] trace: [ust] Do not use zero-length format strings (avoid compiler warning) Lluís Vilanova
2011-09-20 7:32 ` [Qemu-devel] [PATCH 1/3] trace: Fix print format for "mipsnet_write" Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110920162239.GA30824@Krystal \
--to=compudj@krystal.dyndns.org \
--cc=ltt-dev@lists.casi.polymtl.ca \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).