From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59075) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R635o-00073h-2p for qemu-devel@nongnu.org; Tue, 20 Sep 2011 12:22:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R635m-0002mr-Cx for qemu-devel@nongnu.org; Tue, 20 Sep 2011 12:22:43 -0400 Received: from mail.openrapids.net ([64.15.138.104]:45410 helo=blackscsi.openrapids.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R635m-0002mc-AE for qemu-devel@nongnu.org; Tue, 20 Sep 2011 12:22:42 -0400 Received: from localhost (localhost [127.0.0.1]) by blackscsi.openrapids.net (Postfix) with ESMTP id 07E05140455 for ; Tue, 20 Sep 2011 12:22:41 -0400 (EDT) Received: from blackscsi.openrapids.net ([127.0.0.1]) by localhost (blackscsi.openrapids.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JlwY3LV1P9rF for ; Tue, 20 Sep 2011 12:22:40 -0400 (EDT) Received: from krystal.dyndns.org (localhost [127.0.0.1]) by blackscsi.openrapids.net (Postfix) with ESMTP id B5C88140456 for ; Tue, 20 Sep 2011 12:22:39 -0400 (EDT) Date: Tue, 20 Sep 2011 12:22:39 -0400 From: Mathieu Desnoyers Message-ID: <20110920162239.GA30824@Krystal> References: <20110916165933.16620.4383.stgit@ginnungagap.bsc.es> <20110916165938.16620.54932.stgit@ginnungagap.bsc.es> <20110920115202.GB23976@stefanha-thinkpad.localdomain> <87ty87z849.fsf@ginnungagap.bsc.es> <20110920143112.GA14814@Krystal> <87k493w8mt.fsf@ginnungagap.bsc.es> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <87k493w8mt.fsf@ginnungagap.bsc.es> Subject: Re: [Qemu-devel] [ltt-dev] [PATCH 2/3] trace: [ust] Do not use 'm' in event argument names (used by ust macros) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Llu=EDs?= Vilanova Cc: Stefan Hajnoczi , ltt-dev@lists.casi.polymtl.ca, qemu-devel@nongnu.org * Llu=C3=ADs Vilanova (vilanova@ac.upc.edu) wrote: >=20 > I don't know about the portability requirements in UST, but if supporting= only > gcc is an option, you can simply use this line in the macro: >=20 > void *__tp_cb_data __attribute__((unused)); >=20 Done. See commit 34dca3cc6e0b230c988b16117b967a094560f4ed. > Even with this fixed, there still seem to be problems with events without > parameters: >=20 > DECLARE_TRACE(ust_slavio_misc_update_irq_raise, TP_PROTO(void), TP_ARGS= ()); > #define trace_slavio_misc_update_irq_raise trace_ust_slavio_misc_update= _irq_raise >=20 > ./trace.h: In function =E2=80=98__trace_ust_slavio_misc_update_irq_rais= e=E2=80=99: > ./trace.h:361:1: error: =E2=80=98void=E2=80=99 must be the only paramet= er > ./trace.h:361:1: error: expected expression before =E2=80=98)=E2=80=99 = token > ./trace.h:361:1: error: too many arguments to function =E2=80=98(void (= *)(void *))__tp_it_func=E2=80=99 >=20 TRACEPOINT_EVENT_NOARGS(name, TP_FIELDS()) should be used there. Thanks! Mathieu > The debian/testing version of ust is 0.15, and the sources have a ChangeL= og with > this at the top: >=20 > 2011-07-15 ust 0.15 > * Add backward compability for tracepoint API (still planned for > deprecation, but should make the transition smoother). >=20 >=20 > Lluis >=20 > --=20 > "And it's much the same thing with knowledge, for whenever you learn > something new, the whole world becomes that much richer." > -- The Princess of Pure Reason, as told by Norton Juster in The Phantom > Tollbooth >=20 --=20 Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com