* Re: [Qemu-devel] [PATCH] MAINTAINERS: update maintainer for target-arm and ARM devboards
2011-09-20 15:18 [Qemu-devel] [PATCH] MAINTAINERS: update maintainer for target-arm and ARM devboards Peter Maydell
@ 2011-09-20 15:25 ` Anthony Liguori
2011-09-20 21:39 ` Paul Brook
2011-09-20 16:52 ` Edgar E. Iglesias
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Anthony Liguori @ 2011-09-20 15:25 UTC (permalink / raw)
To: Peter Maydell; +Cc: Paul Brook, qemu-devel, patches
On 09/20/2011 10:18 AM, Peter Maydell wrote:
> Add myself as co-maintainer alongside Paul Brook for the TCG ARM
> guest implementation (target-arm) and the ARM dev boards (integratorcp,
> realview, stellaris, versatilepb).
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
Acked-by: Anthony Liguori <aliguori@us.ibm.com>
Paul, speak now or forever hold your peace ;-)
Regards,
Anthony Liguori
> ---
> MAINTAINERS | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 72b2099..b2369c2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -62,6 +62,7 @@ F: target-alpha/
>
> ARM
> M: Paul Brook<paul@codesourcery.com>
> +M: Peter Maydell<peter.maydell@linaro.org>
> S: Maintained
> F: target-arm/
>
> @@ -168,6 +169,7 @@ F: hw/gumstix.c
>
> Integrator CP
> M: Paul Brook<paul@codesourcery.com>
> +M: Peter Maydell<peter.maydell@linaro.org>
> S: Maintained
> F: hw/integratorcp.c
>
> @@ -193,6 +195,7 @@ F: hw/palm.c
>
> Real View
> M: Paul Brook<paul@codesourcery.com>
> +M: Peter Maydell<peter.maydell@linaro.org>
> S: Maintained
> F: hw/realview*
>
> @@ -203,11 +206,13 @@ F: hw/spitz.c
>
> Stellaris
> M: Paul Brook<paul@codesourcery.com>
> +M: Peter Maydell<peter.maydell@linaro.org>
> S: Maintained
> F: hw/stellaris.c
>
> Versatile PB
> M: Paul Brook<paul@codesourcery.com>
> +M: Peter Maydell<peter.maydell@linaro.org>
> S: Maintained
> F: hw/versatilepb.c
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: update maintainer for target-arm and ARM devboards
2011-09-20 15:25 ` Anthony Liguori
@ 2011-09-20 21:39 ` Paul Brook
0 siblings, 0 replies; 6+ messages in thread
From: Paul Brook @ 2011-09-20 21:39 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Peter Maydell, qemu-devel, patches
> > Add myself as co-maintainer alongside Paul Brook for the TCG ARM
> > guest implementation (target-arm) and the ARM dev boards (integratorcp,
> > realview, stellaris, versatilepb).
> >
> > Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
>
> Acked-by: Anthony Liguori <aliguori@us.ibm.com>
>
> Paul, speak now or forever hold your peace ;-)
I approve in general principle, and haven't being paying enough attention to
make a specific technical judgement.
For the record I consider having multiple maintainers to be a good thing.
IMO the role of a maintainer should be to make sure sub-par code is brought up
up to standard before it is comitted. Approving patches is easy, rejecting
the bad patches[1] is where you add value. Maintainership is more an
indication that you're competent to review those bits of code than a grant of
control.
Paul
[1] With constructive criticism on how to fix the problem.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: update maintainer for target-arm and ARM devboards
2011-09-20 15:18 [Qemu-devel] [PATCH] MAINTAINERS: update maintainer for target-arm and ARM devboards Peter Maydell
2011-09-20 15:25 ` Anthony Liguori
@ 2011-09-20 16:52 ` Edgar E. Iglesias
2011-09-20 18:24 ` Juan Quintela
2011-09-23 18:51 ` Anthony Liguori
3 siblings, 0 replies; 6+ messages in thread
From: Edgar E. Iglesias @ 2011-09-20 16:52 UTC (permalink / raw)
To: Peter Maydell; +Cc: Anthony Liguori, patches, qemu-devel, Paul Brook
On Tue, Sep 20, 2011 at 04:18:46PM +0100, Peter Maydell wrote:
> Add myself as co-maintainer alongside Paul Brook for the TCG ARM
> guest implementation (target-arm) and the ARM dev boards (integratorcp,
> realview, stellaris, versatilepb).
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: update maintainer for target-arm and ARM devboards
2011-09-20 15:18 [Qemu-devel] [PATCH] MAINTAINERS: update maintainer for target-arm and ARM devboards Peter Maydell
2011-09-20 15:25 ` Anthony Liguori
2011-09-20 16:52 ` Edgar E. Iglesias
@ 2011-09-20 18:24 ` Juan Quintela
2011-09-23 18:51 ` Anthony Liguori
3 siblings, 0 replies; 6+ messages in thread
From: Juan Quintela @ 2011-09-20 18:24 UTC (permalink / raw)
To: Peter Maydell; +Cc: Anthony Liguori, patches, qemu-devel, Paul Brook
Peter Maydell <peter.maydell@linaro.org> wrote:
> Add myself as co-maintainer alongside Paul Brook for the TCG ARM
> guest implementation (target-arm) and the ARM dev boards (integratorcp,
> realview, stellaris, versatilepb).
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Juan Quintela <quintela@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: update maintainer for target-arm and ARM devboards
2011-09-20 15:18 [Qemu-devel] [PATCH] MAINTAINERS: update maintainer for target-arm and ARM devboards Peter Maydell
` (2 preceding siblings ...)
2011-09-20 18:24 ` Juan Quintela
@ 2011-09-23 18:51 ` Anthony Liguori
3 siblings, 0 replies; 6+ messages in thread
From: Anthony Liguori @ 2011-09-23 18:51 UTC (permalink / raw)
To: Peter Maydell; +Cc: patches, qemu-devel, Paul Brook
On 09/20/2011 10:18 AM, Peter Maydell wrote:
> Add myself as co-maintainer alongside Paul Brook for the TCG ARM
> guest implementation (target-arm) and the ARM dev boards (integratorcp,
> realview, stellaris, versatilepb).
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> MAINTAINERS | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 72b2099..b2369c2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -62,6 +62,7 @@ F: target-alpha/
>
> ARM
> M: Paul Brook<paul@codesourcery.com>
> +M: Peter Maydell<peter.maydell@linaro.org>
> S: Maintained
> F: target-arm/
>
> @@ -168,6 +169,7 @@ F: hw/gumstix.c
>
> Integrator CP
> M: Paul Brook<paul@codesourcery.com>
> +M: Peter Maydell<peter.maydell@linaro.org>
> S: Maintained
> F: hw/integratorcp.c
>
> @@ -193,6 +195,7 @@ F: hw/palm.c
>
> Real View
> M: Paul Brook<paul@codesourcery.com>
> +M: Peter Maydell<peter.maydell@linaro.org>
> S: Maintained
> F: hw/realview*
>
> @@ -203,11 +206,13 @@ F: hw/spitz.c
>
> Stellaris
> M: Paul Brook<paul@codesourcery.com>
> +M: Peter Maydell<peter.maydell@linaro.org>
> S: Maintained
> F: hw/stellaris.c
>
> Versatile PB
> M: Paul Brook<paul@codesourcery.com>
> +M: Peter Maydell<peter.maydell@linaro.org>
> S: Maintained
> F: hw/versatilepb.c
>
^ permalink raw reply [flat|nested] 6+ messages in thread