From: Christoph Hellwig <hch@lst.de>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com,
Frediano Ziglio <freddy77@gmail.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] block: avoid SIGUSR2
Date: Tue, 20 Sep 2011 20:08:00 +0200 [thread overview]
Message-ID: <20110920180800.GA28285@lst.de> (raw)
In-Reply-To: <CAJSP0QUvzRtJxLPSttsmvYy8JZqjKCWYAnHThB+B=cWHpHNHgA@mail.gmail.com>
On Mon, Sep 19, 2011 at 03:05:47PM +0100, Stefan Hajnoczi wrote:
> On Mon, Sep 19, 2011 at 12:54 PM, Frediano Ziglio <freddy77@gmail.com> wrote:
> > @@ -547,7 +549,7 @@ static int posix_aio_flush(void *opaque)
> >
> > ?static PosixAioState *posix_aio_state;
> >
> > -static void aio_signal_handler(int signum)
> > +static void posix_aio_notify_event(void)
> > ?{
> > ? ? if (posix_aio_state) {
>
> Seems like this if statement is always true, hence the condition can
> be removed. The posix_aio_state global is always non-NULL here.
It is. In addition to dropping it I'd also recommend moving the
function up so that it's above it's caller.
Btw, what is the point of the qemu_service_io? Calling qemu_notify_event
directly would seem a lot more obvious, given that the name actually
gives a hint on what it actually does.
next prev parent reply other threads:[~2011-09-20 18:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 11:54 [Qemu-devel] [PATCH 0/2][RFC?] Remove SIGUSR2 from posix-aio Frediano Ziglio
2011-09-19 11:54 ` [Qemu-devel] [PATCH 1/2] block: avoid storing a constant in qemu_paiocb structure Frediano Ziglio
2011-09-19 11:54 ` [Qemu-devel] [PATCH 2/2] block: avoid SIGUSR2 Frediano Ziglio
2011-09-19 14:05 ` Stefan Hajnoczi
2011-09-20 18:08 ` Christoph Hellwig [this message]
2011-09-19 14:08 ` [Qemu-devel] [PATCH 0/2][RFC?] Remove SIGUSR2 from posix-aio Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110920180800.GA28285@lst.de \
--to=hch@lst.de \
--cc=aliguori@us.ibm.com \
--cc=freddy77@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).