From: Paul Brook <paul@codesourcery.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] MAINTAINERS: update maintainer for target-arm and ARM devboards
Date: Tue, 20 Sep 2011 22:39:50 +0100 [thread overview]
Message-ID: <201109202239.50515.paul@codesourcery.com> (raw)
In-Reply-To: <4E78B082.8080703@us.ibm.com>
> > Add myself as co-maintainer alongside Paul Brook for the TCG ARM
> > guest implementation (target-arm) and the ARM dev boards (integratorcp,
> > realview, stellaris, versatilepb).
> >
> > Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
>
> Acked-by: Anthony Liguori <aliguori@us.ibm.com>
>
> Paul, speak now or forever hold your peace ;-)
I approve in general principle, and haven't being paying enough attention to
make a specific technical judgement.
For the record I consider having multiple maintainers to be a good thing.
IMO the role of a maintainer should be to make sure sub-par code is brought up
up to standard before it is comitted. Approving patches is easy, rejecting
the bad patches[1] is where you add value. Maintainership is more an
indication that you're competent to review those bits of code than a grant of
control.
Paul
[1] With constructive criticism on how to fix the problem.
next prev parent reply other threads:[~2011-09-20 21:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 15:18 [Qemu-devel] [PATCH] MAINTAINERS: update maintainer for target-arm and ARM devboards Peter Maydell
2011-09-20 15:25 ` Anthony Liguori
2011-09-20 21:39 ` Paul Brook [this message]
2011-09-20 16:52 ` Edgar E. Iglesias
2011-09-20 18:24 ` Juan Quintela
2011-09-23 18:51 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109202239.50515.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=aliguori@us.ibm.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).