From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6J3K-0002ad-1U for qemu-devel@nongnu.org; Wed, 21 Sep 2011 05:25:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R6J3I-0002NT-Nl for qemu-devel@nongnu.org; Wed, 21 Sep 2011 05:25:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16356) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6J3I-0002NK-At for qemu-devel@nongnu.org; Wed, 21 Sep 2011 05:25:12 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p8L9PB2W029013 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 21 Sep 2011 05:25:11 -0400 Date: Wed, 21 Sep 2011 10:24:56 +0100 From: "Daniel P. Berrange" Message-ID: <20110921092456.GA28096@redhat.com> References: <4E78D516.7080803@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4E78D516.7080803@redhat.com> Subject: Re: [Qemu-devel] [libvirt] [PATCH] qemu: Fix shutdown regression Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: libvir-list@redhat.com, QEMU Developers On Tue, Sep 20, 2011 at 12:01:58PM -0600, Eric Blake wrote: > On 09/20/2011 11:39 AM, Jiri Denemark wrote: > >The commit that prevents disk corruption on domain shutdown > >(96fc4784177ecb70357518fa863442455e45ad0e) causes regression with QEMU > >0.14.* and 0.15.* because of a regression bug in QEMU that was fixed > >only recently in QEMU git. With affected QEMU binaries, domains cannot > >be shutdown properly and stay in a paused state. This patch tries to > >avoid this by sending SIGKILL to 0.1[45].* QEMU processes. Though we > >wait a bit more between sending SIGTERM and SIGKILL to reduce the > >possibility of virtual disk corruption. > >--- > > src/qemu/qemu_capabilities.c | 7 +++++++ > > src/qemu/qemu_capabilities.h | 1 + > > src/qemu/qemu_process.c | 19 +++++++++++++------ > > 3 files changed, 21 insertions(+), 6 deletions(-) > > ACK. But it would be nice if upstream qemu could give us a more > reliable indication of whether the qemu SIGTERM bug is fixed, so > that we don't corrupt data on a patched 0.14 or 0.15 qemu. That is, > as part of fixing the bug in qemu, we should also update -help text > or something similar, so that libvirt can avoid making decisions > solely on version numbers. -help is traditionally just a way to detecting features. I think it would be rather an abuse of -help to start adding information about every bugfix that affects mgmt apps too. So I think a version number check is sufficient in this case. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|