From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37798)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1R8GSm-0002ox-Fm
	for qemu-devel@nongnu.org; Mon, 26 Sep 2011 15:03:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1R8GSl-0003FL-Gm
	for qemu-devel@nongnu.org; Mon, 26 Sep 2011 15:03:36 -0400
Received: from mx1.redhat.com ([209.132.183.28]:15139)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1R8GSl-0003Eh-8Y
	for qemu-devel@nongnu.org; Mon, 26 Sep 2011 15:03:35 -0400
Date: Mon, 26 Sep 2011 22:03:47 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20110926190347.GC22278@redhat.com>
References: <20110926163509.020984459@linux.vnet.ibm.com>
	<20110926163728.368010654@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110926163728.368010654@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH V9 1/5] Support for TPM command line options
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: serge@hallyn.com, qemu-devel@nongnu.org, anbang.ruan@cs.ox.ac.uk, andreas.niederl@iaik.tugraz.at

On Mon, Sep 26, 2011 at 12:35:10PM -0400, Stefan Berger wrote:
> +void tpm_display_backend_drivers(FILE *out)
> +{
> +    int i;
> +
> +    fprintf(out, "Supported TPM types (choose only one):\n");
> +
> +    for (i = 0; bes[i] != NULL; i++) {
> +        fprintf(out, "%12s   %s",
> +                bes[i]->id, bes[i]->desc());
> +        fprintf(out, "\n");
> +    }
> +    fprintf(out, "\n");
> +}

This dumps to stderr and so for qmp users it won't be correctly ordered.
I'd suggest simply using error_report. This means '?' goes to stderr,
not stdout, but that is consistent with e.g. -device '?'.