From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44379)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1R8QDX-0002SE-1I
	for qemu-devel@nongnu.org; Tue, 27 Sep 2011 01:28:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1R8QD5-0006eC-AZ
	for qemu-devel@nongnu.org; Tue, 27 Sep 2011 01:28:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56941)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1R8QD5-0006e6-2K
	for qemu-devel@nongnu.org; Tue, 27 Sep 2011 01:28:03 -0400
Date: Tue, 27 Sep 2011 08:28:25 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20110927052824.GA4690@redhat.com>
References: <20110926163509.020984459@linux.vnet.ibm.com>
	<20110926163729.645611239@linux.vnet.ibm.com>
	<20110926190905.GD22278@redhat.com>
	<4E812B6F.4030905@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E812B6F.4030905@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH V9 2/5] Add TPM (frontend) hardware
 interface (TPM TIS) to Qemu
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: avi@redhat.com, serge@hallyn.com, qemu-devel@nongnu.org, anbang.ruan@cs.ox.ac.uk, andreas.niederl@iaik.tugraz.at

On Mon, Sep 26, 2011 at 09:48:31PM -0400, Stefan Berger wrote:
> >>+
> >>+    rc = tpm_tis_do_startup_tpm(s);
> >>+    if (rc != 0) {
> >>+        goto err_exit;
> >>+    }
> >>+
> >>+    return 0;
> >>+
> >>+ err_exit:
> >Missing cleanup?
> >
> True. Fixed.
> I had previously looked around in other devices how they were doing
> it and had often seen them not cleaning up, either.
> 
>    Stefan

We should fix that too I guess ...