From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:41625)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1R8ZRm-00073y-S7
	for qemu-devel@nongnu.org; Tue, 27 Sep 2011 11:19:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1R8ZRe-0004qm-CO
	for qemu-devel@nongnu.org; Tue, 27 Sep 2011 11:19:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60703)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1R8ZRe-0004qd-0S
	for qemu-devel@nongnu.org; Tue, 27 Sep 2011 11:19:42 -0400
Date: Tue, 27 Sep 2011 18:20:43 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20110927152041.GB13889@redhat.com>
References: <CAJJyHjK3ySHcHRC6eB2cPS=-=1JnqsWV4tXG0xDJgxpS2jG4=w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJJyHjK3ySHcHRC6eB2cPS=-=1JnqsWV4tXG0xDJgxpS2jG4=w@mail.gmail.com>
Subject: Re: [Qemu-devel] Try to integrate the Xen PCI Passthrough code into
 linux: have pci_regs conflict with libpci.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Xen Devel <xen-devel@lists.xensource.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Alexander Graf <agraf@suse.de>, QEMU-devel <qemu-devel@nongnu.org>, Alex Williamson <alex.williamson@redhat.com>

On Tue, Sep 27, 2011 at 04:02:23PM +0100, Anthony PERARD wrote:
> Hi,
> 
> I'm trying to integrate the Xen PCI Passthrough code into Qemu. But we
> use libpci, and it's not friendly with pci_regs.h.
> 
> So can I replace pci_regs by the libpci one?

I prefer sticking to pci_regs in linux.

> Should I avoid to include both? (by having a "hook" the libpci functions)
> Or do you have any other suggestions?
> 
> Thanks,
> Regards,

Can you avoid libpci? It was very useful before sysfs, but
on modern systems there isn't much that it does.

-- 
MST