From: Amit Shah <amit.shah@redhat.com>
To: Markus Armbruster <armbru@redhat.com>,
Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu list <qemu-devel@nongnu.org>, Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] virtio-serial-bus: Add per-port stats for received, sent, discarded bytes
Date: Wed, 28 Sep 2011 14:39:29 +0530 [thread overview]
Message-ID: <20110928090929.GA12218@amit-x200.redhat.com> (raw)
In-Reply-To: <m3r53jtgpe.fsf@blackfin.pond.sub.org>
On (Wed) 14 Sep 2011 [15:07:57], Markus Armbruster wrote:
> Amit Shah <amit.shah@redhat.com> writes:
>
> > This commit adds port-specific stats for the number of bytes received,
> > sent and discarded. They can be seen in the 'info qtree' monitor output
> > for the specific port.
> >
> > This data can be used to check for data loss bugs (or disprove such
> > claims). It can also be used for accounting, if there's such a need.
> >
> > The stats remain valid throughout the lifetime of the port. Unplugging a
> > port will reset the stats. The numbers are not reset across port
> > opens/closes.
> >
> > Signed-off-by: Amit Shah <amit.shah@redhat.com>
>
> I'm not sure "info qtree" is the right place to show device stats. I
> guess it's the only existing place that comes to mind. Anthony, what do
> you think?
Ping?
Amit
prev parent reply other threads:[~2011-09-28 9:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 7:29 [Qemu-devel] [PATCH 0/3] virtio-serial: Bug fix, add stats for bytes transferred Amit Shah
2011-09-14 7:29 ` [Qemu-devel] [PATCH 1/3] virtio-serial-bus: add port arg to discard_vq_data() Amit Shah
2011-09-14 12:52 ` Markus Armbruster
2011-09-14 13:36 ` Amit Shah
2011-09-14 7:29 ` [Qemu-devel] [PATCH 2/3] virtio-serial-bus: discard data in already popped-out elem Amit Shah
2011-09-14 7:29 ` [Qemu-devel] [PATCH 3/3] virtio-serial-bus: Add per-port stats for received, sent, discarded bytes Amit Shah
2011-09-14 13:07 ` Markus Armbruster
2011-09-28 9:09 ` Amit Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110928090929.GA12218@amit-x200.redhat.com \
--to=amit.shah@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).