From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:41042)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1R8q97-00010V-B4
	for qemu-devel@nongnu.org; Wed, 28 Sep 2011 05:09:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1R8q93-0007XC-9a
	for qemu-devel@nongnu.org; Wed, 28 Sep 2011 05:09:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:16612)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1R8q93-0007Wn-2b
	for qemu-devel@nongnu.org; Wed, 28 Sep 2011 05:09:37 -0400
Date: Wed, 28 Sep 2011 14:39:29 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20110928090929.GA12218@amit-x200.redhat.com>
References: <cover.1315985199.git.amit.shah@redhat.com>
	<cover.1315985199.git.amit.shah@redhat.com>
	<ed20b527eb3abcff61946cb7111ead3ec8d8cc03.1315985199.git.amit.shah@redhat.com>
	<m3r53jtgpe.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3r53jtgpe.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] [PATCH 3/3] virtio-serial-bus: Add per-port stats
 for received, sent, discarded bytes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu list <qemu-devel@nongnu.org>, Juan Quintela <quintela@redhat.com>

On (Wed) 14 Sep 2011 [15:07:57], Markus Armbruster wrote:
> Amit Shah <amit.shah@redhat.com> writes:
> 
> > This commit adds port-specific stats for the number of bytes received,
> > sent and discarded.  They can be seen in the 'info qtree' monitor output
> > for the specific port.
> >
> > This data can be used to check for data loss bugs (or disprove such
> > claims). It can also be used for accounting, if there's such a need.
> >
> > The stats remain valid throughout the lifetime of the port. Unplugging a
> > port will reset the stats.  The numbers are not reset across port
> > opens/closes.
> >
> > Signed-off-by: Amit Shah <amit.shah@redhat.com>
> 
> I'm not sure "info qtree" is the right place to show device stats.  I
> guess it's the only existing place that comes to mind.  Anthony, what do
> you think?

Ping?

		Amit