From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37492) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9LTv-00030O-Rv for qemu-devel@nongnu.org; Thu, 29 Sep 2011 14:37:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R9LTu-0004Mo-Pw for qemu-devel@nongnu.org; Thu, 29 Sep 2011 14:37:15 -0400 Received: from mail-wy0-f173.google.com ([74.125.82.173]:65278) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9LTu-0004Mi-LW for qemu-devel@nongnu.org; Thu, 29 Sep 2011 14:37:14 -0400 Received: by wyh22 with SMTP id 22so338921wyh.4 for ; Thu, 29 Sep 2011 11:37:13 -0700 (PDT) Date: Thu, 29 Sep 2011 18:16:51 +0100 From: Stefan Hajnoczi Message-ID: <20110929171651.GA1624@stefanha-thinkpad.localdomain> References: <1317299989-30571-1-git-send-email-harsh@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1317299989-30571-1-git-send-email-harsh@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [RFC PATCH 0/2] Replace 9p debug infrastructure with Qemu Tracing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Harsh Prateek Bora Cc: qemu-devel@nongnu.org, aneesh.kumar@linux.vnet.ibm.com On Thu, Sep 29, 2011 at 06:09:47PM +0530, Harsh Prateek Bora wrote: > This patchset introduces Qemu Tracing to 9p pdu handlers and removes the > existing debug infrastructure which becomes less meaningful after the > introduction of coroutines. Parallel operations creates a messy output and > filtering becomes difficult. With Qemu tracing in place, we can selectively > enable/disable trace-events and the trace log can be further filtered using > analysis scripts. > > Harsh Prateek Bora (2): > Introduce tracing for 9p pdu handlers > Remove virtio-9p-debug.* infra since we are using Qemu Tracing now. > > Makefile.objs | 2 +- > hw/9pfs/virtio-9p-debug.c | 646 --------------------------------------------- > hw/9pfs/virtio-9p-debug.h | 6 - > hw/9pfs/virtio-9p.c | 70 +++++- > trace-events | 47 ++++ > 5 files changed, 110 insertions(+), 661 deletions(-) > delete mode 100644 hw/9pfs/virtio-9p-debug.c > delete mode 100644 hw/9pfs/virtio-9p-debug.h Reviewed-by: Stefan Hajnoczi It would also be neat to wire up 9p pdu's to the pcap code in net/dump.c so it's possible to capture 9p sessions and look at them with wireshark. Stefan