From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RAdpP-0005Hy-9x for qemu-devel@nongnu.org; Mon, 03 Oct 2011 04:24:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RAdpO-0000ca-EI for qemu-devel@nongnu.org; Mon, 03 Oct 2011 04:24:47 -0400 Received: from mail-bw0-f45.google.com ([209.85.214.45]:36898) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RAdpO-0000cU-9M for qemu-devel@nongnu.org; Mon, 03 Oct 2011 04:24:46 -0400 Received: by bkbzv15 with SMTP id zv15so5226410bkb.4 for ; Mon, 03 Oct 2011 01:24:44 -0700 (PDT) Date: Mon, 3 Oct 2011 10:24:39 +0200 From: "Edgar E. Iglesias" Message-ID: <20111003082439.GA15288@edde.se.axis.com> References: <1317419169-8551-1-git-send-email-weil@mail.berlios.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1317419169-8551-1-git-send-email-weil@mail.berlios.de> Subject: Re: [Qemu-devel] [PATCH] etrax: Fix wrong conditional statement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-devel@nongnu.org On Fri, Sep 30, 2011 at 11:46:09PM +0200, Stefan Weil wrote: > cppcheck reports an error: the conditional statement is always true. > > I assume that the register should be masked with 3, > but could not test the code. > > Please test before applying this patch. Thanks Stefan, I tested & committed a patch that removes the bogus if statement. Cheers