Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for guest

[Marcelo Tosatti <mtosatti@redhat.com>]

On Sun, Sep 25, 2011 at 10:47:46PM +0800, Liu, Jinsong wrote:
> Marcelo Tosatti wrote:
> > On Fri, Sep 23, 2011 at 04:25:51PM +0800, Liu, Jinsong wrote:
> >> Marcelo Tosatti wrote:
> >>> On Thu, Sep 22, 2011 at 04:55:52PM +0800, Liu, Jinsong wrote:
> >>>>> From 4d5b83aba40ce0d421add9a41a6c591a8590a32e Mon Sep 17 00:00:00
> >>>>> 2001
> >>>> From: Liu, Jinsong <jinsong.liu@intel.com>
> >>>> Date: Thu, 22 Sep 2011 14:00:08 +0800
> >>>> Subject: [PATCH 2/2] KVM: emulate lapic tsc deadline timer for
> >>>> guest 
> >>>> 
> >>>> This patch emulate lapic tsc deadline timer for guest:
> >>>> Enumerate tsc deadline timer capability by CPUID;
> >>>> Enable tsc deadline timer mode by lapic MMIO;
> >>>> Start tsc deadline timer by WRMSR;
> >>>> 
> >>>> Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com> ---
> >>>>  arch/x86/include/asm/kvm_host.h |    2 +
> >>>>  arch/x86/kvm/kvm_timer.h        |    2 +
> >>>>  arch/x86/kvm/lapic.c            |  123
> >>>>  ++++++++++++++++++++++++++++++++------- arch/x86/kvm/lapic.h
> >>>>  |    3 + arch/x86/kvm/x86.c              |   16 +++++-
> >>>>  5 files changed, 123 insertions(+), 23 deletions(-)
> >>> 
> >>> Looks good, please rebase against branch master of
> >>> 
> >>> git://github.com/avikivity/kvm.git
> >> 
> >> Rebased as attached.
> >> 
> >> Thanks,
> >> Jinsong
> > 
> > Please write a simple test case to arm a lapic timer via wrmsr (see
> > https://github.com/avikivity/kvm-unit-tests).
> > 
> > Kernel patches have been applied, thanks.
> 
> Marcelo,
> 
> I'm not quite clear the purpose and usage of test case of the kvm-unit-tests.
> Can you give me some hint?

The purpose is to add unit tests for new features (such as lapic
deadline timer). There are examples that make it relatively easy to
construct new test case (or modify existing ones to accomodate new
tests).

Please add a new test case for lapic deadline timer, thanks.