From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46623)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1RAztA-00059Z-1x
	for qemu-devel@nongnu.org; Tue, 04 Oct 2011 03:58:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1RAzt8-0002LJ-6D
	for qemu-devel@nongnu.org; Tue, 04 Oct 2011 03:58:08 -0400
Received: from mail-ww0-f53.google.com ([74.125.82.53]:39160)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1RAzt7-0002L1-SB
	for qemu-devel@nongnu.org; Tue, 04 Oct 2011 03:58:06 -0400
Received: by wwg14 with SMTP id 14so267539wwg.10
	for <qemu-devel@nongnu.org>; Tue, 04 Oct 2011 00:58:05 -0700 (PDT)
Date: Tue, 4 Oct 2011 08:18:07 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20111004071807.GA8149@stefanha-thinkpad.localdomain>
References: <20110929232824.7CBA73FC28@buildbot.b1-systems.de>
	<CAJSP0QU_+oJ6Wv55XSOxqJWc0fw2xhAo46UuUiB2sFkiHhpyng@mail.gmail.com>
	<87pqih2im0.fsf@skywalker.in.ibm.com>
	<87mxdl2h0c.fsf@skywalker.in.ibm.com>
	<20111003073752.GA31578@stefanha-thinkpad.localdomain>
	<87ehyu2w99.fsf@skywalker.in.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87ehyu2w99.fsf@skywalker.in.ibm.com>
Subject: Re: [Qemu-devel] buildbot failure in qemu on default_x86_64_rhel5
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: agraf@suse.de, gollub@b1-systems.de, qemu-devel@nongnu.org, lcapitulino@redhat.com

On Mon, Oct 03, 2011 at 04:10:50PM +0530, Aneesh Kumar K.V wrote:
> On Mon, 3 Oct 2011 08:37:52 +0100, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> > On Sat, Oct 01, 2011 at 03:03:23PM +0530, Aneesh Kumar K.V wrote:
> > > +#ifndef CONFIG_UTIMENSAT
> > > +    /*
> > > +     * We support handle fs driver only if all related
> > > +     * syscalls are provided by host.
> > > +     */
> > 
> > Perhaps a ./configure check should be added to see whether the handle
> > syscalls are supported instead of using CONFIG_UTIMENSAT.
> > 
> 
> We already do check for handle syscall. Since glibc doesn't have the
> this syscall yet, I added the check in virtio-9p-handle.c as below

CONFIG_UTIMENSAT is defined when the host has glibc >= 2.6.

Handle syscalls are available on Linux 2.6.39 but not exposed by glibc.

Therefore CONFIG_UTIMENSAT has nothing to do with handle syscalls and
does not mean handle syscalls are supported.  I would drop that hunk of
the patch or test for the actual handle syscalls in ./configure.

Stefan