From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDKvE-0003qu-Fs for qemu-devel@nongnu.org; Mon, 10 Oct 2011 14:49:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RDKvD-0004uN-7I for qemu-devel@nongnu.org; Mon, 10 Oct 2011 14:49:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33075) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDKvC-0004u7-Uv for qemu-devel@nongnu.org; Mon, 10 Oct 2011 14:49:55 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9AInrWd007223 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 10 Oct 2011 14:49:53 -0400 Date: Mon, 10 Oct 2011 15:49:50 -0300 From: Luiz Capitulino Message-ID: <20111010154950.5df5f253@doriath> In-Reply-To: <1317729885-17534-1-git-send-email-pbonzini@redhat.com> References: <1317729885-17534-1-git-send-email-pbonzini@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] runstate: do not discard runstate changes when paused List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On Tue, 4 Oct 2011 14:04:45 +0200 Paolo Bonzini wrote: > Trying to migrate a paused machine fails. The reason is that > the RSTATE_PRE_MIGRATE is reached with vm_stop, and this > transition is eaten when the vm is already paused. This patch > fixes the problem by always going through runstate_set and > always notifying the new state. > > Signed-off-by: Paolo Bonzini As the discussion on this subject is taking too long, I'll apply this one. The only problem is that it doesn't fully fix the problem: we need a transition from paused to finish-migrate (yes, I've clarified the name in another series). Could you fix that and resend please? > --- > cpus.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/cpus.c b/cpus.c > index 8978779..eab8ff6 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -128,6 +128,8 @@ static void do_vm_stop(RunState state) > qemu_aio_flush(); > bdrv_flush_all(); > monitor_protocol_event(QEVENT_STOP, NULL); > + } else { > + runstate_set(state); > } > } >