From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDYnS-0007vk-Du for qemu-devel@nongnu.org; Tue, 11 Oct 2011 05:38:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RDYnR-0002l4-H0 for qemu-devel@nongnu.org; Tue, 11 Oct 2011 05:38:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38288) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDYnR-0002ku-6P for qemu-devel@nongnu.org; Tue, 11 Oct 2011 05:38:49 -0400 Date: Tue, 11 Oct 2011 11:36:16 +0200 From: Alon Levy Message-ID: <20111011093616.GA32387@bow.tlv.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] "console: Properly switch consoles for screen dumps" breaks qxl screen dump List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel@nongnu.org Hi Jan, I've recently found the $SUBJECT, it's commit f81bdefb63243e82d16ce49332f7cf74d10b8f27. I'd like to fix it without breaking anything, can you provide me with the test that your original patch fixed? Alon p.s. for a simple command line with a single console (not even sure how to get multiple) the following fixes my problem, I expect it doesn't introduce any problems? diff --git a/console.c b/console.c index 6dfcc47..5a709fe 100644 --- a/console.c +++ b/console.c @@ -1067,6 +1067,10 @@ void console_select(unsigned int index) if (index >= MAX_CONSOLES) return; + if (active_console == consoles[index]) { + fprintf(stderr, "not changing console, not required\n"); + return; + } if (active_console) { active_console->g_width = ds_get_width(active_console->ds); active_console->g_height = ds_get_height(active_console->ds);