From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RE104-0005Ye-3X for qemu-devel@nongnu.org; Wed, 12 Oct 2011 11:45:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RE102-00050t-BG for qemu-devel@nongnu.org; Wed, 12 Oct 2011 11:45:44 -0400 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:51164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RE101-00050h-OA for qemu-devel@nongnu.org; Wed, 12 Oct 2011 11:45:42 -0400 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [202.81.31.245]) by e23smtp07.au.ibm.com (8.14.4/8.13.1) with ESMTP id p9CFjXJ4028133 for ; Thu, 13 Oct 2011 02:45:33 +1100 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p9CFjQra2105594 for ; Thu, 13 Oct 2011 02:45:32 +1100 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p9CFjPbn018621 for ; Thu, 13 Oct 2011 02:45:26 +1100 Date: Thu, 13 Oct 2011 02:43:06 +1100 From: David Gibson Message-ID: <20111012154306.GS4849@truffala.fritz.box> References: <1315197304-22469-2-git-send-email-david@gibson.dropbear.id.au> <20111002102547.GC30747@redhat.com> <4E883CF4.6060606@redhat.com> <20111002105238.GE30747@redhat.com> <4E8843DB.1020404@redhat.com> <20111002111700.GF30747@redhat.com> <4E885286.30905@redhat.com> <20111002121426.GK30747@redhat.com> <20111012030746.GO4849@truffala.fritz.box> <20111012072201.GB7514@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111012072201.GB7514@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/9] Add stub functions for PCI device models to do PCI DMA List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: aliguori@us.ibm.com, kraxel@redhat.com, joerg.roedel@amd.com, agraf@suse.de, qemu-devel@nongnu.org, Avi Kivity , eduard.munteanu@linux360.ro, rth@twiddle.net On Wed, Oct 12, 2011 at 09:22:01AM +0200, Michael S. Tsirkin wrote: > On Wed, Oct 12, 2011 at 02:07:46PM +1100, David Gibson wrote: > > Um.. why? PCI is defined by the spec to be LE, so I don't see that we > > need explicit endianness versions for PCI helpers. > > LE in the spec only applies to structures defined by the spec, > that is pci configuration and msix tables in device memory. Well, true. But when was the last time you saw a PCI device with BE registers? I think it's a rare enough case that the individual device models can reswap themselves. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson