From: "Daniel P. Berrange" <berrange@redhat.com>
To: ronnie sahlberg <ronniesahlberg@gmail.com>
Cc: kwolf@redhat.com, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
dlaor@redhat.com, qemu-devel@nongnu.org,
fujita.tomonori@lab.ntt.co.jp, owasserm@redhat.com,
pbonzini@redhat.com, hch@lst.de
Subject: Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI
Date: Thu, 13 Oct 2011 11:01:49 +0100 [thread overview]
Message-ID: <20111013100149.GG22901@redhat.com> (raw)
In-Reply-To: <CAN05THRoeSEweBde86p9EQ_8YN7iJ7ajsk0t9Cmih_RJiVSfew@mail.gmail.com>
On Thu, Oct 13, 2011 at 08:46:54PM +1100, ronnie sahlberg wrote:
> Previous version of the patch received very positive feedback and
> several expressed seeing positive value of a built-in initiator.
> I updated patch from feedback 3 weeks ago and Stefan kindly reviewed it.
>
>
> Is there some other problem with the patch I am not aware of that I
> should address?
>
> I have been trying to push this patch in different versions since
> December last year.
> There is obviously a problem here I am not aware of.
> Please advice what the problem is and I will try to rectify it.
>
>
> Please advice on how I can move forward. I feel a bit at roads end
> here. Please help.
I can't comment much on the code, but I'm supportive of QEMU gaining
this feature, because it addresses a number of use cases not satisfied
by using iSCSI via the host OS's block layer.
> >>> You can specify devices using a iscsi url of the form :
> >>> iscsi://[<username>[:<password>@]]<host>[:<port]/<target-iqn-name>/<lun>
> >>> When using authentication, the password can optionally be set with
> >>> LIBISCSI_CHAP_PASSWORD="password" to avoid it showing up in the process list
I'm not a fan of sending passwords via command line args, or
environment variables. Env variables *can* be exposed via
the process list, albeit not to unprivileged users. More
critically, env variables will end up in logfiles like
/var/log/libvirt/qemu/$GUESTNAME.log, and in data reported
to distro bug trackers, via tools like sosreport which
capture /proc/$PID/environ and aforementioned logfiles.
We have a similar requirement for specifying passwords with
the Ceph/RBD driver, and also for the curl/HTTP block drivers.
We have a monitor command for providing decryption passwords for
QCow2 disks. We could either reuse that for connection passwords,
or perhaps slightly better would be to have a separate command
for connection passwords.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2011-10-13 10:02 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 9:37 [Qemu-devel] [PATCH] Add iSCSI support for QEMU Ronnie Sahlberg
2011-09-21 9:37 ` [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI Ronnie Sahlberg
2011-09-21 9:45 ` Paolo Bonzini
2011-09-21 9:52 ` ronnie sahlberg
2011-09-27 20:08 ` ronnie sahlberg
2011-09-28 5:54 ` Paolo Bonzini
2011-09-29 6:54 ` Stefan Hajnoczi
2011-10-09 20:46 ` ronnie sahlberg
2011-10-13 9:46 ` ronnie sahlberg
2011-10-13 9:48 ` Paolo Bonzini
2011-10-13 9:54 ` Stefan Hajnoczi
2011-10-13 10:01 ` Daniel P. Berrange [this message]
2011-10-13 10:55 ` Daniel P. Berrange
2011-10-13 10:52 ` Kevin Wolf
2011-10-24 13:33 ` Kevin Wolf
2011-10-25 8:04 ` ronnie sahlberg
2011-10-25 8:17 ` Kevin Wolf
2011-10-25 8:23 ` ronnie sahlberg
2011-10-25 8:46 ` Kevin Wolf
2011-10-28 10:46 ` Zhi Yong Wu
-- strict thread matches above, loose matches on Subject: below --
2011-09-10 4:23 [Qemu-devel] [PATCH] Add iSCSI support for QEMU Ronnie Sahlberg
2011-09-10 4:23 ` [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI Ronnie Sahlberg
2011-09-12 9:14 ` Stefan Hajnoczi
2011-09-14 14:36 ` Christoph Hellwig
2011-09-14 15:50 ` Stefan Hajnoczi
2011-09-16 15:53 ` Christoph Hellwig
2011-09-17 7:11 ` Stefan Hajnoczi
2011-09-14 22:51 ` ronnie sahlberg
2011-09-15 8:02 ` Daniel P. Berrange
2011-09-15 9:03 ` Kevin Wolf
2011-09-14 23:08 ` ronnie sahlberg
2011-09-15 6:04 ` Paolo Bonzini
2011-09-15 8:48 ` Dor Laor
2011-09-15 9:11 ` Paolo Bonzini
2011-09-15 11:27 ` ronnie sahlberg
2011-09-15 11:42 ` Dor Laor
2011-09-15 11:46 ` Christoph Hellwig
2011-09-15 12:01 ` Dor Laor
2011-09-15 12:04 ` Paolo Bonzini
2011-09-15 11:58 ` Paolo Bonzini
2011-09-15 12:34 ` Orit Wasserman
2011-09-15 12:58 ` Paolo Bonzini
2011-09-15 16:59 ` Orit Wasserman
2011-09-15 9:44 ` Daniel P. Berrange
2011-09-15 9:10 ` Kevin Wolf
2011-09-15 9:39 ` Paolo Bonzini
2011-09-21 9:48 ` ronnie sahlberg
2011-09-23 9:15 ` Mark Wu
2011-09-23 10:16 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111013100149.GG22901@redhat.com \
--to=berrange@redhat.com \
--cc=dlaor@redhat.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=owasserm@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).