[Qemu-devel] [PATCH] savevm: qemu_savevm_state(): Drop stop VM logic

[Qemu-devel] [PATCH] savevm: qemu_savevm_state(): Drop stop VM logic

[Luiz Capitulino]

qemu_savevm_state() has some logic to stop the VM and to (or not to)
resume it. But this seems to be a big noop, as qemu_savevm_state()
is only called by do_savevm() when the VM is already stopped.

So, let's drop qemu_savevm_state()'s stop VM logic.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 savevm.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/savevm.c b/savevm.c
index bf4d0e7..abb4a60 100644
--- a/savevm.c
+++ b/savevm.c
@@ -1599,12 +1599,8 @@ void qemu_savevm_state_cancel(Monitor *mon, QEMUFile *f)
 
 static int qemu_savevm_state(Monitor *mon, QEMUFile *f)
 {
-    int saved_vm_running;
     int ret;
 
-    saved_vm_running = runstate_is_running();
-    vm_stop(RUN_STATE_SAVE_VM);
-
     if (qemu_savevm_state_blocked(mon)) {
         ret = -EINVAL;
         goto out;
@@ -1626,9 +1622,6 @@ out:
     if (qemu_file_has_error(f))
         ret = -EIO;
 
-    if (!ret && saved_vm_running)
-        vm_start();
-
     return ret;
 }
 
-- 
1.7.7.rc3

Re: [Qemu-devel] [PATCH] savevm: qemu_savevm_state(): Drop stop VM logic

[Michael Roth]

Heh, Anthony and I were puzzling over this just before your patch hit the list.

Looks good :)

Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>

On Thu, 13 Oct 2011 17:27:53 -0300, Luiz Capitulino <lcapitulino@redhat.com> wrote:
> qemu_savevm_state() has some logic to stop the VM and to (or not to)
> resume it. But this seems to be a big noop, as qemu_savevm_state()
> is only called by do_savevm() when the VM is already stopped.
> 
> So, let's drop qemu_savevm_state()'s stop VM logic.
> 
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  savevm.c |    7 -------
>  1 files changed, 0 insertions(+), 7 deletions(-)
> 
> diff --git a/savevm.c b/savevm.c
> index bf4d0e7..abb4a60 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -1599,12 +1599,8 @@ void qemu_savevm_state_cancel(Monitor *mon, QEMUFile *f)
> 
>  static int qemu_savevm_state(Monitor *mon, QEMUFile *f)
>  {
> -    int saved_vm_running;
>      int ret;
> 
> -    saved_vm_running = runstate_is_running();
> -    vm_stop(RUN_STATE_SAVE_VM);
> -
>      if (qemu_savevm_state_blocked(mon)) {
>          ret = -EINVAL;
>          goto out;
> @@ -1626,9 +1622,6 @@ out:
>      if (qemu_file_has_error(f))
>          ret = -EIO;
> 
> -    if (!ret && saved_vm_running)
> -        vm_start();
> -
>      return ret;
>  }
> 
> -- 
> 1.7.7.rc3
> 
> 

-- 
Sincerely,
Mike Roth
IBM Linux Technology Center

Re: [Qemu-devel] [PATCH] savevm: qemu_savevm_state(): Drop stop VM logic

[Kevin Wolf]

Am 13.10.2011 22:27, schrieb Luiz Capitulino:
> qemu_savevm_state() has some logic to stop the VM and to (or not to)
> resume it. But this seems to be a big noop, as qemu_savevm_state()
> is only called by do_savevm() when the VM is already stopped.
> 
> So, let's drop qemu_savevm_state()'s stop VM logic.
> 
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>

Reviewed-by: Kevin Wolf <kwolf@redhat.com>

Re: [Qemu-devel] [PATCH] savevm: qemu_savevm_state(): Drop stop VM logic

[Juan Quintela]

Luiz Capitulino <lcapitulino@redhat.com> wrote:
> qemu_savevm_state() has some logic to stop the VM and to (or not to)
> resume it. But this seems to be a big noop, as qemu_savevm_state()
> is only called by do_savevm() when the VM is already stopped.
>
> So, let's drop qemu_savevm_state()'s stop VM logic.
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>