From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:50586)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mohan@in.ibm.com>) id 1REZKB-0007WU-NL
	for qemu-devel@nongnu.org; Fri, 14 Oct 2011 00:24:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mohan@in.ibm.com>) id 1REZK9-0002em-41
	for qemu-devel@nongnu.org; Fri, 14 Oct 2011 00:24:47 -0400
Received: from e28smtp06.in.ibm.com ([122.248.162.6]:40121)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mohan@in.ibm.com>) id 1REZK8-0002eJ-FG
	for qemu-devel@nongnu.org; Fri, 14 Oct 2011 00:24:45 -0400
Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62])
	by e28smtp06.in.ibm.com (8.14.4/8.13.1) with ESMTP id p9E4OgUA015402
	for <qemu-devel@nongnu.org>; Fri, 14 Oct 2011 09:54:42 +0530
Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66])
	by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p9E4OfUO3244040
	for <qemu-devel@nongnu.org>; Fri, 14 Oct 2011 09:54:41 +0530
Received: from d28av04.in.ibm.com (loopback [127.0.0.1])
	by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p9E4OfWO004434
	for <qemu-devel@nongnu.org>; Fri, 14 Oct 2011 15:24:41 +1100
From: "M. Mohan Kumar" <mohan@in.ibm.com>
Date: Fri, 14 Oct 2011 09:54:38 +0530
References: <1318406014-16911-1-git-send-email-mohan@in.ibm.com>
	<4E95BDAC.6030308@suse.de>
In-Reply-To: <4E95BDAC.6030308@suse.de>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Message-Id: <201110140954.38719.mohan@in.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] Add opt_set_bool function
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?iso-8859-15?q?F=E4rber?= <afaerber@suse.de>
Cc: qemu-devel@nongnu.org

Andreas,

I will repost the patch with boolean type change.

=2D-=20
Regards,
M. Mohan Kumar
On Wednesday, October 12, 2011 09:47:48 PM Andreas F=E4rber wrote:
> Am 12.10.2011 09:53, schrieb M. Mohan Kumar:
> > In addition to qemu_opt_set function, we need a function to set bool
> > value also.
> >=20
> > Signed-off-by: M. Mohan Kumar<mohan@in.ibm.com>
> > ---
> >=20
> >   qemu-option.c |   35 +++++++++++++++++++++++++++++++++++
> >   qemu-option.h |    1 +
> >   2 files changed, 36 insertions(+), 0 deletions(-)
> >=20
> > diff --git a/qemu-option.c b/qemu-option.c
> > index 105d760..d6bc908 100644
> > --- a/qemu-option.c
> > +++ b/qemu-option.c
> > @@ -636,6 +636,41 @@ int qemu_opt_set(QemuOpts *opts, const char *name,
> > const char *value)
> >=20
> >       return 0;
> >  =20
> >   }
> >=20
> > +int qemu_opt_set_bool(QemuOpts *opts, const char *name, int val)
>=20
> Might it make sense to let qemu_opt_{get,set}_bool() use bool type?
>=20
> Andreas