From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1REm8C-0004i5-BO for qemu-devel@nongnu.org; Fri, 14 Oct 2011 14:05:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1REm8A-00023J-Ht for qemu-devel@nongnu.org; Fri, 14 Oct 2011 14:05:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1REm8A-00023B-5F for qemu-devel@nongnu.org; Fri, 14 Oct 2011 14:05:14 -0400 Date: Fri, 14 Oct 2011 15:05:10 -0300 From: Luiz Capitulino Message-ID: <20111014150510.610f6deb@doriath> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH] net: tap-linux: Fix unhelpful error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel Cc: Stefan Hajnoczi , mst@redhat.com I'm getting: could not configure /dev/net/tun (tap%d): Operation not permitted When the ioctl() fails, ifr.ifr_name will most likely not be overwritten. So we better only use it when ifname contains a string. Signed-off-by: Luiz Capitulino --- PS: Trivial tree candidate. net/tap-linux.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/net/tap-linux.c b/net/tap-linux.c index ff8cad0..41d581b 100644 --- a/net/tap-linux.c +++ b/net/tap-linux.c @@ -73,7 +73,11 @@ int tap_open(char *ifname, int ifname_size, int *vnet_hdr, int vnet_hdr_required pstrcpy(ifr.ifr_name, IFNAMSIZ, "tap%d"); ret = ioctl(fd, TUNSETIFF, (void *) &ifr); if (ret != 0) { - error_report("could not configure %s (%s): %m", PATH_NET_TUN, ifr.ifr_name); + if (ifname[0] != '\0') { + error_report("could not configure %s (%s): %m", PATH_NET_TUN, ifr.ifr_name); + } else { + error_report("could not configure %s: %m", PATH_NET_TUN); + } close(fd); return -1; } -- 1.7.7.rc3