From: Paul Brook <paul@codesourcery.com>
To: Dmitry Koshelev <karaghiozis@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ARM GIC and CPU state saving/loading fix
Date: Fri, 14 Oct 2011 16:04:40 +0100 [thread overview]
Message-ID: <201110141604.40963.paul@codesourcery.com> (raw)
In-Reply-To: <CAKUHwZpxH2vUBb9Y_R0uPCMvPhcpNB=yJJFdmJFWfmtbG85_Nw@mail.gmail.com>
> Fixes two trivial indices errors.
No.
You're doing two much in a single patch. While both happen to be bug in the
save/restore code involving arrays, these are not two instances of the same
bug. The justification for each change is completely different.
Even if each change was obviously correct, I believe putting them together
into a single commit makes the result non-trivial. The fact your patch
introduces a bug strongly suggests it shouldn't have been considered trivial
to start with.
> @@ -53,7 +53,7 @@ void cpu_save(QEMUFile *f, void *opaque)
> if (arm_feature(env, ARM_FEATURE_VFP)) {
> - for (i = 0; i < 16; i++) {
> + for (i = 16; i < 32; i++) {
> CPU_DoubleU u;
> u.d = env->vfp.regs[i];
I'm pretty sure this is wrong.
Paul
next prev parent reply other threads:[~2011-10-14 15:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 13:25 [Qemu-devel] [PATCH] ARM GIC and CPU state saving/loading fix Dmitry Koshelev
2011-10-14 13:50 ` Stefan Hajnoczi
2011-10-14 14:57 ` Andreas Färber
2011-10-14 15:04 ` Paul Brook [this message]
2011-10-14 17:07 ` Dmitry Koshelev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110141604.40963.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=karaghiozis@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).