From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFo9y-000374-7z for qemu-devel@nongnu.org; Mon, 17 Oct 2011 10:27:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RFo9s-00006V-4Y for qemu-devel@nongnu.org; Mon, 17 Oct 2011 10:27:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32567) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFo9r-00006O-LV for qemu-devel@nongnu.org; Mon, 17 Oct 2011 10:27:16 -0400 Date: Mon, 17 Oct 2011 16:28:19 +0200 From: "Michael S. Tsirkin" Message-ID: <20111017142818.GG6406@redhat.com> References: <20111017112217.GC4537@redhat.com> <4E9C1123.4070204@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E9C1123.4070204@siemens.com> Subject: Re: [Qemu-devel] [RFC][PATCH 42/45] msix: Introduce msix_init_simple List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Alex Williamson , Marcelo Tosatti , Avi Kivity , "kvm@vger.kernel.org" , "qemu-devel@nongnu.org" On Mon, Oct 17, 2011 at 01:27:31PM +0200, Jan Kiszka wrote: > On 2011-10-17 13:22, Michael S. Tsirkin wrote: > > On Mon, Oct 17, 2011 at 11:28:16AM +0200, Jan Kiszka wrote: > >> Devices models are usually not interested in specifying MSI-X > >> configuration details beyond the number of vectors to provide and the > >> BAR number to use. Layout of an exclusively used BAR and its > >> registration can also be handled centrally. > >> > >> This is the purpose of msix_init_simple. It provides handy services to > >> the existing users. Future users like device assignment may require more > >> detailed setup specification. For them we will (re-)introduce msix_init > >> with the full list of configuration option (in contrast to the current > >> code). > >> > >> Signed-off-by: Jan Kiszka > > > > Well, this seems a bit of a code churn then, doesn't it? > > We are also discussing using memory BAR for virtio-pci for other > > stuff besides MSI-X, so the last user of the _simple variant > > will be ivshmem then? > > We will surely see more MSI-X users over the time. Not sure if they all > mix their MSIX-X BARs with other stuff. But e.g. the e1000 variant I > have here does not. So there should be users in the future. > > Jan Question is, how hard is to pass in the BAR and the offset? > -- > Siemens AG, Corporate Technology, CT T DE IT 1 > Corporate Competence Center Embedded Linux