From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59506)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1RG8wk-0003Aw-9P
	for qemu-devel@nongnu.org; Tue, 18 Oct 2011 08:39:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1RG8we-0005sE-FL
	for qemu-devel@nongnu.org; Tue, 18 Oct 2011 08:39:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60751)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1RG8we-0005s7-5M
	for qemu-devel@nongnu.org; Tue, 18 Oct 2011 08:39:00 -0400
Date: Tue, 18 Oct 2011 14:40:04 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20111018124004.GN28776@redhat.com>
References: <cover.1318843693.git.jan.kiszka@siemens.com>
	<bdbd2c2890972f8fef2d7b9d740b58bda11677e9.1318843693.git.jan.kiszka@siemens.com>
	<20111017121620.GH4537@redhat.com> <4E9C7B3C.3010703@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E9C7B3C.3010703@web.de>
Subject: Re: [Qemu-devel] [RFC][PATCH 22/45] qemu-kvm: msix: Fire mask
 notifier on global mask changes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Alex Williamson <alex.williamson@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, Avi Kivity <avi@redhat.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On Mon, Oct 17, 2011 at 09:00:12PM +0200, Jan Kiszka wrote:
> On 2011-10-17 14:16, Michael S. Tsirkin wrote:
> > On Mon, Oct 17, 2011 at 11:27:56AM +0200, Jan Kiszka wrote:
> >> Also invoke the mask notifier if the global MSI-X mask is modified. For
> >> this purpose, we push the notifier call from the per-vector mask update
> >> to the central msix_handle_mask_update.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > 
> > This is a bugfix, isn't it?
> > If yes it should be separated and put on -stable.
> 
> Yep, will pull this to the front.

I'll apply this to qemu.git, no need to mix bugfixes
with features ...

> > 
> >> ---
> >>  hw/msix.c |   16 +++++++++-------
> >>  1 files changed, 9 insertions(+), 7 deletions(-)
> >>
> >> diff --git a/hw/msix.c b/hw/msix.c
> >> index 739b56f..247b255 100644
> >> --- a/hw/msix.c
> >> +++ b/hw/msix.c
> >> @@ -221,7 +221,15 @@ static bool msix_is_masked(PCIDevice *dev, int vector)
> >>  
> >>  static void msix_handle_mask_update(PCIDevice *dev, int vector)
> >>  {
> >> -    if (!msix_is_masked(dev, vector) && msix_is_pending(dev, vector)) {
> >> +    bool masked = msix_is_masked(dev, vector);
> >> +    int ret;
> >> +
> >> +    if (dev->msix_mask_notifier) {
> >> +        ret = dev->msix_mask_notifier(dev, vector,
> >> +                                      msix_is_masked(dev, vector));
> > 
> > Use 'masked' value here as well?
> 
> Yes.
> 
> Jan
>