From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46479) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGVh6-0006aJ-W0 for qemu-devel@nongnu.org; Wed, 19 Oct 2011 08:56:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RGVh5-0007jA-91 for qemu-devel@nongnu.org; Wed, 19 Oct 2011 08:56:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15255) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGVh4-0007iw-TS for qemu-devel@nongnu.org; Wed, 19 Oct 2011 08:56:27 -0400 Date: Wed, 19 Oct 2011 10:56:19 -0200 From: Luiz Capitulino Message-ID: <20111019105619.4e0813fa@doriath> In-Reply-To: <4E9E1D35.7040202@cn.fujitsu.com> References: <1318613203-25892-1-git-send-email-lcapitulino@redhat.com> <1318613203-25892-3-git-send-email-lcapitulino@redhat.com> <4E9E1D35.7040202@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/5] runstate: Print state transition when invalid List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wen Congyang Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On Wed, 19 Oct 2011 08:43:33 +0800 Wen Congyang wrote: > At 10/15/2011 01:26 AM, Luiz Capitulino Write: > > Makes it easier to debug. > > > > Signed-off-by: Luiz Capitulino > > --- > > vl.c | 4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > diff --git a/vl.c b/vl.c > > index dbf7778..6645720 100644 > > --- a/vl.c > > +++ b/vl.c > > @@ -397,7 +397,9 @@ void runstate_set(RunState new_state) > > { > > if (new_state >= RUN_STATE_MAX || > > !runstate_valid_transitions[current_run_state][new_state]) { > > - fprintf(stderr, "invalid runstate transition\n"); > > + fprintf(stderr, "ERROR: invalid runstate transition: '%s' -> '%s'\n", > > + RunState_lookup[current_run_state], > > + RunState_lookup[new_state]); > > If new_state >= RUN_STATE_MAX, we can not use RunState_lookup. Good catch! > I think it's better to use: > new_state >= RUN_STATE_MAX ? "invalid state" : RunState_lookup[new_state] I prefer to do the following instead: diff --git a/vl.c b/vl.c index 2dce3ae..2a634a7 100644 --- a/vl.c +++ b/vl.c @@ -393,9 +393,12 @@ void runstate_init(void) /* This function will abort() on invalid state transitions */ void runstate_set(RunState new_state) { - if (new_state >= RUN_STATE_MAX || - !runstate_valid_transitions[current_run_state][new_state]) { - fprintf(stderr, "invalid runstate transition\n"); + assert(new_state < RUN_STATE_MAX); + + if (!runstate_valid_transitions[current_run_state][new_state]) { + fprintf(stderr, "ERROR: invalid runstate transition: '%s' -> '%s'\n", + RunState_lookup[current_run_state], + RunState_lookup[new_state]); abort(); } -- 1.7.7.rc3 > > Thanks > Wen Congyang > > > abort(); > > } > > >