From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RH5sW-0007lG-4C for qemu-devel@nongnu.org; Thu, 20 Oct 2011 23:34:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RH5sS-0001gp-SM for qemu-devel@nongnu.org; Thu, 20 Oct 2011 23:34:40 -0400 Date: Fri, 21 Oct 2011 14:34:28 +1100 From: David Gibson Message-ID: <20111021033428.GB6826@truffala.fritz.box> References: <1318897082-27413-1-git-send-email-agraf@suse.de> <4E9D3EE5.8050402@suse.de> <20111018113745.GE6655@truffala.fritz.box> <4EA06A01.5080806@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4EA06A01.5080806@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: Fail configure when libfdt is not available List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Andreas =?iso-8859-1?Q?F=E4rber?= , Alexander Graf On Thu, Oct 20, 2011 at 08:35:45PM +0200, Gerd Hoffmann wrote: > Hi, >=20 > > If there are build problems with libfdt on any platform let me know > > about them. I would like it to build clean as widely as possible, bu= t > > I don't have that great a diversity of build environments, so I have > > to reply on bug reports. >=20 > Fails to build on RHEL-5: >=20 > CC convert-dtsv0-lexer.lex.o > cc1: warnings being treated as errors > convert-dtsv0-lexer.lex.c:693: warning: no previous prototype for =E2=80= =98yylex=E2=80=99 > make: *** [convert-dtsv0-lexer.lex.o] Error 1 This one I can work around, but there's probably not much point because..= . > Removing -Werror from the Makefile gets me a bit further: >=20 > CC dtc-lexer.lex.o > dtc-lexer.lex.c:683: warning: no previous prototype for =E2=80=98yylex=E2= =80=99 > dtc-lexer.l: In function =E2=80=98push_input_file=E2=80=99: > dtc-lexer.l:192: warning: implicit declaration of function > =E2=80=98yypush_buffer_state=E2=80=99 > dtc-lexer.l:192: warning: nested extern declaration of =E2=80=98yypush_= buffer_state=E2=80=99 > dtc-lexer.l: In function =E2=80=98pop_input_file=E2=80=99: > dtc-lexer.l:201: warning: implicit declaration of function > =E2=80=98yypop_buffer_state=E2=80=99 > dtc-lexer.l:201: warning: nested extern declaration of =E2=80=98yypop_b= uffer_state=E2=80=99 > CC dtc-parser.tab.o > LD dtc > dtc-lexer.lex.o: In function `push_input_file': > /home/buildbot/git/dtc/dtc-lexer.l:192: undefined reference to > `yypush_buffer_state' > dtc-lexer.lex.o: In function `pop_input_file': > /home/buildbot/git/dtc/dtc-lexer.l:201: undefined reference to > `yypop_buffer_state' > collect2: ld returned 1 exit status > make: *** [dtc] Error 1 ...this is harder. I do rely fairly heavily on the lex multiple input buffer support for processing includes. I'm not sure when that went in, but obviously after flex 2.5.4. I could rewrite to not rely on the flex stuff and do it myself, but it would be non-trivial, so I'm afraid that fix won't happen particularly soon. > I guess the flex version shipped with RHEL-5 is too old. >=20 > $ rpm -qf $(which lex) > flex-2.5.4a-41.fc6 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other= _ | _way_ _around_! http://www.ozlabs.org/~dgibson