From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RIZ55-0003H9-St for qemu-devel@nongnu.org; Tue, 25 Oct 2011 00:57:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RIZ53-0007L1-F4 for qemu-devel@nongnu.org; Tue, 25 Oct 2011 00:57:43 -0400 Date: Tue, 25 Oct 2011 15:57:31 +1100 From: David Gibson Message-ID: <20111025045731.GA6124@truffala.fritz.box> References: <1319510029-14140-1-git-send-email-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1319510029-14140-1-git-send-email-david@gibson.dropbear.id.au> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Alter CPU state to mask out TCG unimplemented instructions as appropriate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: agraf@suse.de Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On Tue, Oct 25, 2011 at 01:33:49PM +1100, David Gibson wrote: > The CPU state contains two bitmaps, initialized from the CPU spec > which describes which instructions are implemented on the CPU. A > couple of bits are defined which cover instructions (VSX and DFP) > which are not currently implemented in TCG. So far, these are only > used to handle the case of -cpu host because a KVM guest can use > the instructions when the host CPU supports them. > > However, it's a mild layering violation to simply not include those > bits in the CPU descriptions for those CPUs that do support them, > just because we can't handle them in TCG. This patch corrects the > situation, so that the instruction bits _are_ shown correctly in the > cpu spec table, but are masked out from the cpu state in the non-KVM > case. > > Signed-off-by: David Gibson Sorry, disregard, there's a bug in it. Working on it now. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson