From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RInmF-0005xs-QI for qemu-devel@nongnu.org; Tue, 25 Oct 2011 16:39:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RInmE-0000ah-Rq for qemu-devel@nongnu.org; Tue, 25 Oct 2011 16:39:15 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:62173) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RInmE-0000Zz-MO for qemu-devel@nongnu.org; Tue, 25 Oct 2011 16:39:14 -0400 From: Paul Brook Date: Tue, 25 Oct 2011 21:39:07 +0100 References: <201110251927.53924.paul@codesourcery.com> <4EA70947.9050904@twiddle.net> In-Reply-To: <4EA70947.9050904@twiddle.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Message-Id: <201110252139.08448.paul@codesourcery.com> Subject: Re: [Qemu-devel] [PATCH 24/25] vmstate: port arm cpu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: Peter Maydell , aliguori@us.ibm.com, qemu-devel@nongnu.org, Juan Quintela > >> + env->uncached_cpsr = env->cpsr_vmstate & CPSR_M; > >> + cpsr_write(env, env->cpsr_vmstate, 0xffffffff); > > > > [1] Maybe a necessary hack, but still a wart from requiring static table > > driven vmstate descriptions. > > I wonder if we shouldn't make it easier to do what I do for Alpha > with the rather different hack for the fpcr. > > That might avoid some of the other pre/post_load hooks, and the > extra data fields that requires in the cpu structure. Sounds reasonable. Having either woraround is a bit lame. Having ARM and Alpha use different workarounds for the same problem really sucks. Paul