From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48840)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcmvbkbc@gmail.com>) id 1RIlDm-0005qM-Dj
	for qemu-devel@nongnu.org; Tue, 25 Oct 2011 13:55:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcmvbkbc@gmail.com>) id 1RIlDl-0002DC-FU
	for qemu-devel@nongnu.org; Tue, 25 Oct 2011 13:55:30 -0400
Received: from mail-bw0-f45.google.com ([209.85.214.45]:48098)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcmvbkbc@gmail.com>) id 1RIlDl-0002D5-8b
	for qemu-devel@nongnu.org; Tue, 25 Oct 2011 13:55:29 -0400
Received: by bkat2 with SMTP id t2so893157bka.4
	for <qemu-devel@nongnu.org>; Tue, 25 Oct 2011 10:55:28 -0700 (PDT)
From: Max Filippov <jcmvbkbc@gmail.com>
Date: Tue, 25 Oct 2011 21:55:22 +0400
References: <cover.1319550280.git.quintela@redhat.com>
	<2990903a0cc46441449790bcdb216c9b5c895507.1319550280.git.quintela@redhat.com>
In-Reply-To: <2990903a0cc46441449790bcdb216c9b5c895507.1319550280.git.quintela@redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201110252155.22224.jcmvbkbc@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 03/25] vmstate: make all architectures
	export a way to migrate cpu's
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: aliguori@us.ibm.com, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org, Michael Walle <michael@walle.cc>, Paul Brook <paul@codesourcery.com>, Aurelien Jarno <aurelien@aurel32.net>, Richard Henderson <rth@twiddle.net>

> This makes several changes:
> - exports VMStateDescription vmstate_cpu non-static.
> - makes sure that every cpu has a vmstate_cpu or cpu_save/load defined
> - for the architecture that had nothing, it just register the cpu as unmigratable.
> - Depending on CPU_SAVE_VERSION we register old/new migration style
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>

[...snip...]

> diff --git a/target-xtensa/machine.c b/target-xtensa/machine.c
> index ddeffb2..3f98330 100644
> --- a/target-xtensa/machine.c
> +++ b/target-xtensa/machine.c
> @@ -26,13 +26,11 @@
>   */
> 
>  #include "hw/hw.h"
> -#include "hw/boards.h"
> 
> -void cpu_save(QEMUFile *f, void *opaque)
> -{
> -}
> +/* To make this architecture migratable, we need to define cpu state
> +   here.  Other things need to be done elsewhere */
> 
> -int cpu_load(QEMUFile *f, void *opaque, int version_id)
> -{
> -    return 0;
> -}
> +const VMStateDescription vmstate_cpu = {
> +    .name = "cpu",
> +    .unmigratable = 1,
> +};
> 

Acked-by: Max Filippov <jcmvbkbc@gmail.com>

Thanks.
-- Max