From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJL2y-000752-2p for qemu-devel@nongnu.org; Thu, 27 Oct 2011 04:10:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RJL2w-0007vl-I6 for qemu-devel@nongnu.org; Thu, 27 Oct 2011 04:10:43 -0400 Received: from mail-ey0-f173.google.com ([209.85.215.173]:39922) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJL2w-0007ua-6W for qemu-devel@nongnu.org; Thu, 27 Oct 2011 04:10:42 -0400 Received: by mail-ey0-f173.google.com with SMTP id 6so2486272eyh.4 for ; Thu, 27 Oct 2011 01:10:41 -0700 (PDT) Date: Thu, 27 Oct 2011 08:17:41 +0100 From: Stefan Hajnoczi Message-ID: <20111027071741.GC32287@stefanha-thinkpad.localdomain> References: <4EA81C05.5090002@redhat.com> <4EA82BAA.10207@redhat.com> <4EA84115.9090707@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4EA84115.9090707@redhat.com> Subject: Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lucas Meneghel Rodrigues Cc: Kevin Wolf , KVM mailing list , Marcelo Tosatti , QEMU devel , Avi Kivity , Cleber Rosa , Richard Henderson On Wed, Oct 26, 2011 at 03:19:17PM -0200, Lucas Meneghel Rodrigues wrote: > On 10/26/2011 01:47 PM, Kevin Wolf wrote: > >Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues: > >>Hi folks: > >> > >>We've captured a regression with floppy disk on recent qemu (and > >>qemu-kvm, after a code merge). We bisected it to be caused by: > >> > >>commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8 > >>Author: Richard Henderson > >>Date: Mon Aug 15 15:08:45 2011 -0700 > >> > >> fdc: Convert to isa_register_portio_list > >> > >> Signed-off-by: Richard Henderson > >> Signed-off-by: Avi Kivity > >> > >>Since this commit, the guest doesn't see a floppy disk attached to it > >>anymore, blocking kvm autotest ability to install windows guests > >>automatically. This is a big deal for kvm autotest (ruins our automated > >>regression jobs), so please take a look at it. > > > >Can you please try again with the latest block branch? I think there is > >a patch queued that will fix it. > > Kevin, I did try with HEAD of your repo: > > git://repo.or.cz/qemu/kevin.git > > [lmr@freedom qemu-kwolf]$ git branch -r > origin/HEAD -> origin/master > origin/blkqueue > origin/blkqueue-v1 > origin/block > origin/coroutine > origin/coroutine-block > origin/coroutine-devel > origin/devel > origin/ehci > origin/for-anthony > origin/for-stable-0.14 > origin/inplace-conversion > origin/master > > With this repo, master branch, the problem persists. With the block > branch, the problem persists. > > Now, with the blkqueue branch the problem is resolved. Cleber had > the same results booting a FreeDOS floppy. So the fix is indeed in > blkqueue. > > Oh, you might want to check the blkqueue branch, it does have quite > a bunch of set but unused variables, which will cause compilation > errors unless --disable-werror is passed to the configure script. I think blkqueue is an older development branch of the "block queue" feature that Kevin was working on. It is not Kevin's block tree (see his "block" branch). Stefan