From: Stefan Hajnoczi <stefanha@gmail.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] net: tap-linux: Fix unhelpful error message
Date: Fri, 28 Oct 2011 08:40:27 +0100 [thread overview]
Message-ID: <20111028074027.GA18132@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <20111014150510.610f6deb@doriath>
On Fri, Oct 14, 2011 at 03:05:10PM -0300, Luiz Capitulino wrote:
> I'm getting:
>
> could not configure /dev/net/tun (tap%d): Operation not permitted
>
> When the ioctl() fails, ifr.ifr_name will most likely not be overwritten.
> So we better only use it when ifname contains a string.
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>
> PS: Trivial tree candidate.
>
> net/tap-linux.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
Thanks, applied to the trivial patches -next tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches-next
Stefan
prev parent reply other threads:[~2011-10-28 8:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 18:05 [Qemu-devel] [PATCH] net: tap-linux: Fix unhelpful error message Luiz Capitulino
2011-10-27 18:51 ` Luiz Capitulino
2011-10-28 7:40 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111028074027.GA18132@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).